camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (CAMEL-3852) camel-cache - Should use Camel style constant keys
Date Wed, 20 Apr 2011 10:26:05 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022051#comment-13022051
] 

Claus Ibsen edited comment on CAMEL-3852 at 4/20/11 10:24 AM:
--------------------------------------------------------------

Thanks.

It would be good to specify what's the key name in the exception, eg in this
throw new CacheException("Cache Key is not specified in message header or endpoint URL.");

throw new CacheException("Cache key: " + CacheContestants.CACHE_KEY + " is not specified in
message header or endpoint URL.");

I wonder if we should support the old keys for 1 or 2 Camel versions, but mark them as @deprecated
on the wiki page. This gives people a chance to migrate? Then you can support by checking
for both the new and old keys. Then we can remove the old keys in a couple of releases or
maybe in Camel 3

      was (Author: davsclaus):
    Thanks.

It would be good to specify what's the key name in the exception, eg in this
throw new CacheException("Cache Key is not specified in message header or endpoint URL.");

throw new CacheException("Cache key: " + CacheContestants.CACHE_KEY + " is not specified in
message header or endpoint URL.");

I wonder if we should support the old keys for 1 or 2 Camel versions, but mark them as @deprecated
on the wiki page. This gives people a chance to migrate?
  
> camel-cache - Should use Camel style constant keys
> --------------------------------------------------
>
>                 Key: CAMEL-3852
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3852
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-cache
>    Affects Versions: 2.7.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: CAMEL-3852.patch
>
>
> The CacheConstant use all upper cases and they are not using the Camel style which we
should use.
> It should be
> "CamelCacheAdd" instead of "ADD"
> and so forth.
> This also ensures those headers is not propagated over remote transports as they should
not.
> In fact we should consider removing those headers in the camel-cache code as they are
just input parameters to control the operation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message