camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <>
Subject [jira] [Commented] (CAMEL-3892) Refresh of the FreeMarker Component
Date Sun, 24 Apr 2011 09:45:05 GMT


Claus Ibsen commented on CAMEL-3892:

Fernando can you ZIP the camel-freemarker component and attach that file?

We cant accept your current patch as is, as the diff is to extreme. Eg you delete all existing
files, and add new files.
A patch should only diff the changes, and respect the existing code format / layout and only
alter the code needed to be changed.

So if you have ZIP of the source, I can better grab the pieces we need.

> Refresh of the FreeMarker Component
> -----------------------------------
>                 Key: CAMEL-3892
>                 URL:
>             Project: Camel
>          Issue Type: Improvement
>         Environment: All Camel environments.
>            Reporter: Fernando Ribeiro
>            Priority: Minor
>             Fix For: 2.8.0
>         Attachments: freemarker.patch
> I've made a number of small changes to the FreeMarker component:
> - General re-format
> - Added constants for the "encoding" and "contentCache" parameters
> - Removed the unused FREEMARKER_RESOURCE constant
> - Removed the unnecessary "FREEMARKER_" prefix of the FREEMARKER_RESOURCE_URI and FREEMARKER_TEMPLATE
> - Removed the unnecessary getExchangePattern method
> - Replaced the NoCacheStorage class by a call to a constructor of the Template class,
that doesn't use any cache
> - Added a default value for the "encoding" parameter (the platform's default)
> - Added a specific exception class to support global exception handlers
> - Renamed all classes from Free*m*arker (wrong) to Free*M*arker
> - Renamed properties from CamelFree*m*arkerResourceUri (wrong) to CamelFree*M*arkerResourceUri
and CamelFree*m*arkerTemplate to CamelFree*M*arker
> - Implemented isDebugEnabled by log.debug, as suggested in CAMEL-3759
> - Improved log messages
> All tests run successfully.

This message is automatically generated by JIRA.
For more information on JIRA, see:

View raw message