camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-3773) Apache Camel version banner is wrong in uber-jar
Date Thu, 10 Mar 2011 11:30:59 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005036#comment-13005036
] 

Claus Ibsen commented on CAMEL-3773:
------------------------------------

Thanks for the patch. 

However with loading resources using classloader can unfortunately be a bit tricky depending
on the host platform.
For example OSGi, JBoss, J2EE app servers etc may not work as easily as you would have thought.

So we need to test your patch that it works seamless. Which it ought to do as you load a resource
from within the same JAR that the given class is from. But we have seen issues in the past.


> Apache Camel version banner is wrong in uber-jar
> ------------------------------------------------
>
>                 Key: CAMEL-3773
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3773
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.6.0
>            Reporter: Arkadi Shishlov
>            Assignee: Claus Ibsen
>            Priority: Minor
>              Labels: uber-jar
>             Fix For: 2.8.0
>
>         Attachments: camel-getVersion-uber-jar.diff
>
>
> At context start a version banner is printed to the log:
> Apache Camel 2.6.0 (CamelContext: camel) started in 2.436 seconds
> The version string is calculated by ServiceSupport.getVersion():
> {code}
> Package aPackage = getClass().getPackage();
> if (aPackage != null) {
>     version = aPackage.getImplementationVersion();
>     if (version == null) {
>         version = aPackage.getSpecificationVersion();
>     }
> }
> {code}
> but, in Maven shade-plugin packaged project (to create single uber-jar for distribution
to SE environment), the Manifest versions are project version, not Camel. So the wrong version
is printed. It would be nice to have this improved to print real Camel version.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message