Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Message-ID: <24306869.85861295545425080.JavaMail.jira@thor>
Date: Thu, 20 Jan 2011 12:43:45 -0500 (EST)
From: "Claus Ibsen (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Commented: (CAMEL-3562) BindyFixedLengthDataFormat does a
 trim on Fixed Length record
In-Reply-To: <12230783.70341295483744005.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CAMEL-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984301#action_12984301 ] 

Claus Ibsen commented on CAMEL-3562:
------------------------------------

I think the option {{trimRecordOnUnmarshal}} is a bit to verbose. Is it possible to name it {{trim}}.

I think frankly it should not trim by default (although it does this now).
Then you get the fixed length as is, which you feels more natural fixed lengtth formats.

Any thoughts?


> BindyFixedLengthDataFormat does a trim on Fixed Length record
> -------------------------------------------------------------
>
>                 Key: CAMEL-3562
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3562
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-bindy
>    Affects Versions: 2.4.0
>            Reporter: Ashwin Karpe
>            Assignee: Ashwin Karpe
>         Attachments: CAMEL-3562.patch
>
>
> BindyFixedLengthDataFormat does a trim on Fixed Length record, although Fixed Length recordare strictly positional in nature and may contain lot of fillers with empty spaces, doing a trim causes Bindy to fail the message length validation and exception is thrown on message length 
> // Read the line 
> String line = scanner.nextLine().trim(); 
> Should be changed to 
> // Read the line 
> String line = scanner.nextLine(); 
> Or a conditional option should be provided in FixedLengthRecord annotation whether or not to trim the entire record

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.