camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claus Ibsen <claus.ib...@gmail.com>
Subject Re: [HEADS UP] - Migrating of slf4j in progress - please dont do major commits
Date Mon, 31 Jan 2011 15:54:19 GMT
Hi

Okay seems ready for one of the first commits for the migration.
There is an issue with OSGi blueprint, which I will have to revisit.
That OSGi stuff can as usual be a bit tricky to decipher wtf is wrong.


On Mon, Jan 31, 2011 at 3:37 PM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
> On Mon, Jan 31, 2011 at 3:10 PM, Hadrian Zbarcea <hzbarcea@gmail.com> wrote:
>> Claus, if you do it incrementally, and commit only one major component at a time
(the small ones could go together) it will be less painful for you and others.
>> Many thanks for the heads up.
>>
>
> Yeah I will try that. Currently I have 200 changes in camel-core and
> about 160 in all the others.
> Those are just the first migration effort to have a complete build and
> test that works.
>
> I may have to break this into 2 commits (1 = core, 2 = other) to not
> have one giant commit.
>
>
> The remainder work is then easy as its just to run the migrator on all
> the camel components, examples and so forth.
> And to update the pom.xml file so slf4j-log4j bridge is included.
>
>
>> Hadrian
>>
>>
>> On Jan 31, 2011, at 7:51 AM, Claus Ibsen wrote:
>>
>>> Hi
>>>
>>> I am migrating from commons-logging to slf4j which means alot of files
>>> will be touched by switching the logger.
>>> https://issues.apache.org/jira/browse/CAMEL-3605?focusedCommentId=12988746#comment-12988746
>>>
>>> There is a migrating tool to do this, so that part is easy
>>> http://www.slf4j.org/migrator.html
>>>
>>> However a few components need to have adjusted pom.xml file and a few
>>> other changes.
>>>
>>> I have currently migrated what's minimum required, which is
>>> camel-core, camel-spring, camel-blueprint and some components which
>>> was dependent on stuff from camel-core which have changed slightly.
>>>
>>> I am currently running full unit test to ensure all code compiles and
>>> tests successfully before committing any changes.
>>>
>>> Any regular or small commits is okay to commit to Apache trunk.
>>>
>>> But if you do a lot of refactoring then could you wait a bit, until
>>> the slf4j migrating has been completed.
>>> Its just easier as I will have to do multiple commits to get it fully migrated.
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Claus Ibsen
>>> -----------------
>>> FuseSource
>>> Email: cibsen@fusesource.com
>>> Web: http://fusesource.com
>>> Twitter: davsclaus
>>> Blog: http://davsclaus.blogspot.com/
>>> Author of Camel in Action: http://www.manning.com/ibsen/
>>
>>
>
>
>
> --
> Claus Ibsen
> -----------------
> FuseSource
> Email: cibsen@fusesource.com
> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.blogspot.com/
> Author of Camel in Action: http://www.manning.com/ibsen/
>



-- 
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/

Mime
View raw message