camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-3239) camel-quartz should require unique timername
Date Fri, 07 Jan 2011 12:41:47 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-3239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978762#action_12978762
] 

Claus Ibsen commented on CAMEL-3239:
------------------------------------

Personally I dislike the
{code}
 @Test (expected = FailedToCreateRouteException.class)
{code}

As you dont really test when the exception occurred and what information it contains.
In your unit test it could be because of anything. Even when starting the first Camel instance.

What you want to test that it happens when starting the 2nd because of duplicate name. So
you need to try .. catch and check the exception message contains this information.

Remember this exception is what the Camel end user see and all he got as information to know
why it fails.

> camel-quartz should require unique timername
> --------------------------------------------
>
>                 Key: CAMEL-3239
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3239
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-quartz
>    Affects Versions: 2.4.0
>            Reporter: Bengt Rodehav
>            Assignee: Tracy Snell
>            Priority: Minor
>             Fix For: 2.6.0
>
>         Attachments: patchfile.txt
>
>
> I'm using camel-quartz (Camel 2.4) and have some problems with the timer name (part of
the URI).
> It seems that if I have two different routes (using camel-quartz) with the same timername,
only one of the quartz endpoints will be activated, e g:
> from("quartz://mytimername"?cron=0+*+*+*+*+?+*").to(endpoint1)
> from("quartz://mytimername"?cron=30+*+*+*+*+?+*").to(endpoint2)
> If I make sure that the timernames are unique, both quartz endpoints will work. Thus
I conclude that the timername must be unique (maybe this is a quartz thing and not a camel-quartz
thing).
> However, I get no indication that something is wrong since the camel route is started
and looks fine although the quartz endpoint will never trigger. This is not a good situation.
In my case I use this for monitoring purposes. I thought that the monitoring worked fine but
it was actually never triggered at all.
> I'm not sure if this due to camel-quartz or quartz itself. However, if it is possible
for camel-quartz to determine that the endpoint was created OK (not OK if duplicate timer
names), then this should case the camel context to fail.
> I run this in an OSGi environment (Karaf 1.6.0). Thus routes like the above can be created
independent of each other which makes it hard to guarantee that the timername is unique.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message