camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-3562) BindyFixedLengthDataFormat does a trim on Fixed Length record
Date Fri, 21 Jan 2011 10:12:43 GMT

    [ https://issues.apache.org/jira/browse/CAMEL-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984659#action_12984659
] 

Claus Ibsen commented on CAMEL-3562:
------------------------------------

We actually fixed the wrong problem.

If you have a fixed length record with leading and/or trailing spaces such as (I use dash
as space)

"----30Claus-----------Ibsen---------"

Then what bindy did was trim that

"30Claus-----------Ibsen"

Which is just plain wrong, it should never trim it. 

I have removed this new option and improve the unit test to test for a record with trailing
spaces.

> BindyFixedLengthDataFormat does a trim on Fixed Length record
> -------------------------------------------------------------
>
>                 Key: CAMEL-3562
>                 URL: https://issues.apache.org/jira/browse/CAMEL-3562
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-bindy
>    Affects Versions: 2.4.0
>            Reporter: Ashwin Karpe
>            Assignee: Ashwin Karpe
>             Fix For: 2.6.0
>
>         Attachments: CAMEL-3562.patch, UPD-CAMEL-3562.patch
>
>
> BindyFixedLengthDataFormat does a trim on Fixed Length record, although Fixed Length
recordare strictly positional in nature and may contain lot of fillers with empty spaces,
doing a trim causes Bindy to fail the message length validation and exception is thrown on
message length 
> // Read the line 
> String line = scanner.nextLine().trim(); 
> Should be changed to 
> // Read the line 
> String line = scanner.nextLine(); 
> Or a conditional option should be provided in FixedLengthRecord annotation whether or
not to trim the entire record

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message