camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bengt Rodehav (JIRA)" <>
Subject [jira] Commented: (CAMEL-3309) Stepwise change of directory unfit for production (ftp/ftps/sftp)
Date Mon, 08 Nov 2010 18:12:00 GMT


Bengt Rodehav commented on CAMEL-3309:

Claus, I kind of thought that this was your intention but that's not how it works. I confirmed
in my tests that I have to set
stepwise=true even for the producer to work. The reason is that in the buildDirectory() method
there is a finally block
that calls changeCurrentDirectory() which acts differently depending on the stepwise parameter.
A few posts back I
showed how that code could be changed in SftpOperations to become independent of the stepwise
parameter. It's in
the post with the timestamp "08/Nov/10 03:06 AM". FtpOperations must be changed in a similar
way to become 
independent of the stepwise parameter. If you change in those two places then the code will
be in accord with the wiki.

About the recursive problem Claus. Do you want me to create a JIRA ticket for that? I wanted
to wait until you have
verified the problem I found just to make sure the problem isn't specific to my local environment.

> Stepwise change of directory unfit for production (ftp/ftps/sftp)
> -----------------------------------------------------------------
>                 Key: CAMEL-3309
>                 URL:
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 2.5.0
>            Reporter: Bengt Rodehav
>            Assignee: Claus Ibsen
>             Fix For: 2.6.0
>         Attachments: camel-ftp.patch
> In Camel 2.5, the logic for changing directory for ftp/ftps/sftp has changed in order
to fix the problems discussed in the following thread:
> In Camel 2.5 changing of the remote directory is now done in a stepwise manner. This
is a strategy not fit for production since it assumes that the logged in ftp/ftps/sftp user
has access to all intermediate directories all the way down to its home directory. This is
rarely the case.
> Also, when testing ftp/sftp on Serv-U, a Windows based ftp/ftps/sftp server, it turns
out that it reports the current directory in a "Windows way", e g /C:/temp/servu/user/sample/file2sftp.
The topmost folder is not "/" but "/C:". This also breaks the new stepwise way of changing
directory since it always tries to change to "/" if an absolute path is used.
> I propose to introduce a configuration property to enable/disable stepwise changing of
directories where disabling it should be the default. I will upload a patch shortly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message