camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bengt Rodehav (JIRA)" <>
Subject [jira] Commented: (CAMEL-3309) Stepwise change of directory unfit for production (ftp/ftps/sftp)
Date Mon, 08 Nov 2010 10:47:02 GMT


Bengt Rodehav commented on CAMEL-3309:

I've now tested ftp(consumer and producer) as well as sftp(consumer and producer) ant it works.
I haven't tested ftps since I think it reuses the logic from ftp - right?

The four tests succeed when I set "stepwise=false", otherwise they fail. I assume this is
your intention.

When looking at the code it seems like you've changed your approach a little bit (correct
me if I'm wrong). The stepwise parameter is now used in two different ways:

1. When consuming, the directory is not changed at all if stepwise=false
2. When producing, the directory is changed (because it has to I guess) but it's not done
in a stepwise manner if stepwise=false

In summary, stepwise=false sometimes prevents changing of directory at all and sometimes just
prevents the changing of directory to be done in a stepwise manner (as the name implies).
It works but it's a bit confusing what the stepwise parameter actually means. Perhaps we should
start thinking about how many configuration parameters we need and what they shall be called?

> Stepwise change of directory unfit for production (ftp/ftps/sftp)
> -----------------------------------------------------------------
>                 Key: CAMEL-3309
>                 URL:
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-ftp
>    Affects Versions: 2.5.0
>            Reporter: Bengt Rodehav
>            Assignee: Claus Ibsen
>         Attachments: camel-ftp.patch
> In Camel 2.5, the logic for changing directory for ftp/ftps/sftp has changed in order
to fix the problems discussed in the following thread:
> In Camel 2.5 changing of the remote directory is now done in a stepwise manner. This
is a strategy not fit for production since it assumes that the logged in ftp/ftps/sftp user
has access to all intermediate directories all the way down to its home directory. This is
rarely the case.
> Also, when testing ftp/sftp on Serv-U, a Windows based ftp/ftps/sftp server, it turns
out that it reports the current directory in a "Windows way", e g /C:/temp/servu/user/sample/file2sftp.
The topmost folder is not "/" but "/C:". This also breaks the new stepwise way of changing
directory since it always tries to change to "/" if an absolute path is used.
> I propose to introduce a configuration property to enable/disable stepwise changing of
directories where disabling it should be the default. I will upload a patch shortly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message