Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Received-SPF: pass (athena.apache.org: domain of willem.jiang@gmail.com
 designates 74.125.83.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=vp7NE1s+s74XydJ/6yb8uVvJ/14sZaf6AryqIvduBh8vONZRbfgQ0MJEk6IOwQuiPs
         mWOehfmV9BdKZ+SneNx7kJQHAoa2UgpRJNkdgIZtMwJr7SIhTrXbCbdxkQblgT3gpBFB
         E0DthRIvYVROTzLtn+/wq8k2CYX7OGnHQnW50=
Message-ID: <4CB5A44B.9090601@gmail.com>
Date: Wed, 13 Oct 2010 20:21:31 +0800
From: Willem Jiang <willem.jiang@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US;
 rv:1.9.2.9) Gecko/20100915 Lightning/1.0b2 Thunderbird/3.1.4
MIME-Version: 1.0
To: dev@camel.apache.org
Subject: Re: svn commit: r1022017 -
 /camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultExecutorServiceStrategy.java
References: <20101013075310.2207E238890B@eris.apache.org>
 <AANLkTi=ZWdqkzwHjFWbh0hVQzD-aWs0SfuNYt8R26fbT@mail.gmail.com>
In-Reply-To: <AANLkTi=ZWdqkzwHjFWbh0hVQzD-aWs0SfuNYt8R26fbT@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

OK, I will change the code to throw the IllegalArguementException for 
this case.

On 10/13/10 7:58 PM, Claus Ibsen wrote:
> Hi
>
> This is rather ugly to silently change 0 to 1 without end user noticing.
> Instead lets thrown an IllegalArgumentException and require core pool
> size to be 1 or higher.
>
> Then in Camel 3 we can allow a core size of 0. Which the thread pool
> in JDK 1.6 seems to accept better than 1.5.
>
>
> On Wed, Oct 13, 2010 at 9:53 AM,<ningjiang@apache.org>  wrote:
>> Author: ningjiang
>> Date: Wed Oct 13 07:53:09 2010
>> New Revision: 1022017
>>
>> URL: http://svn.apache.org/viewvc?rev=1022017&view=rev
>> Log:
>> CAMEL-3220 try to fix the test hang of ThreadsZeroInCoreAndMaxPoolTest
>>
>> Modified:
>>     camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultExecutorServiceStrategy.java
>>
>> Modified: camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultExecutorServiceStrategy.java
>> URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultExecutorServiceStrategy.java?rev=1022017&r1=1022016&r2=1022017&view=diff
>> ==============================================================================
>> --- camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultExecutorServiceStrategy.java (original)
>> +++ camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultExecutorServiceStrategy.java Wed Oct 13 07:53:09 2010
>> @@ -269,7 +269,13 @@ public class DefaultExecutorServiceStrat
>>
>>          // the thread name must not be null
>>          ObjectHelper.notNull(name, "ThreadName");
>> -
>> +
>> +        // If we set the corePoolSize to be 0, the whole camel application will hang in JDK5
>> +        // just add a check here to set the corePoolSize to be 1
>> +        if (corePoolSize == 0) {
>> +            corePoolSize = 1;
>> +        }
>> +
>>          ExecutorService answer = ExecutorServiceHelper.newThreadPool(threadNamePattern, name, corePoolSize, maxPoolSize, keepAliveTime,
>>                                                                       timeUnit, maxQueueSize, rejectedExecutionHandler, daemon);
>>          onThreadPoolCreated(answer);
>>
>>
>>
>
>
>


-- 
Willem
----------------------------------
Open Source Integration: http://www.fusesource.com
Blog:    http://willemjiang.blogspot.com (English)
          http://jnn.javaeye.com (Chinese)
Twitter: http://twitter.com/willemjiang