camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <>
Subject [jira] Commented: (CAMEL-3144) camel-ftp: fileExist=Fail not honored when producer works in FTP root path
Date Wed, 22 Sep 2010 06:56:40 GMT


Claus Ibsen commented on CAMEL-3144:

Btw the patch is buggy. It should return null if there is no path, but it returns the name
of the file. I have fixed that as well.
Running full tests before committing fixes and additional unit tests.

Hadrian we should take time to add tests for patches when they discover a bug in which we
don't have an unit test for.

> camel-ftp: fileExist=Fail not honored when producer works in FTP root path
> --------------------------------------------------------------------------
>                 Key: CAMEL-3144
>                 URL:
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core, camel-ftp
>    Affects Versions: 2.4.0
>         Environment: Camel on Linux; IIS FTP server 
>            Reporter: Raphaƫl Luta
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.5.0
>         Attachments: FileUtil.patch
> when using a route with ftp producer such as :
>  <to uri="ftp://user@host/?fileExist=Fail&fileName=test&password=mypass" />
> The route will not correctly fail if the fileName already exists.
> It will work in any sub-directory:
>  <to uri="ftp://user@host/mydir?fileExist=Fail&fileName=test&password=mypass"
> The root cause of the bug is an incorrect test in org.apache.camel.util.FileUtil.onlyPath()
in component camel-core.
> This method returns null when the parameter string is "/". It should return "/".
> The attached patch fixes the issue.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message