camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bengt Rodehav (JIRA)" <>
Subject [jira] Commented: (CAMEL-1350) camel-quickfix component in apache camel distribution
Date Wed, 29 Sep 2010 07:33:43 GMT


Bengt Rodehav commented on CAMEL-1350:


I think the approach you suggest works really fine. Since you allow an arbitrary number of
"listeners" it is possible to intercept all messages this way - login messages included. The
login example is well suited to be included in the documentation.

One thing that warrants an explanation is "both scenarios require the Camel processor to be
executing in the same thread as the QFJ engine". I think I know what you mean but I think
it is really important that this is clear to all developers using this component.

I assume, as long as we don't start additional threads, that a specific message will be sent
through all routes that are configured to "listen" to that message (by specifying the same
configuration file and a combination of filters that cause them to match the message). Is
that true? If yes, do we need to make the ordering explicit? Do we need to be able to determine
what route the message shall first be sent through? I'm not sure what I think about this but
I think that this is an area that will have to be documented in good way.

You also state that: "It's ok to pass messages to other threads but be sure the message is
persisted locally first since you will not be able to rely on transport-level resends via
FIX." Do you by this mean that the message is regarded as "processed" by QuickFixJ when it
has passed through all routes, that reside in the same thread as the QFJ engine, that "match"
the message? This is really important to know for a developer in order to prevent "lost messages".

Although very flexible, I'm a bit concerned that the concept of having multiple routes listening
to the same message can be a bit confusing and lead to programming errors (that can cause
lost messages). I'm all for flexibility but I think you should add an example to the documentation
that uses more than one thread and clearly show how you persist the message in a route residing
in the same thread as the QFJ engine. Maybe a best-practice could be developed for this pattern?

I'm not a Camel expert like many who have commented on this JIRA ticket. But, isn't it very
unusual for a component to be "natively" multicast - meaning that the same message can be
sent to multiple routes? That feature probably needs to be pointed out and explained clearly.
Personally, I'm for that solution but I haven't adapted my brain to that way of thinking yet.

> camel-quickfix component in apache camel distribution
> -----------------------------------------------------
>                 Key: CAMEL-1350
>                 URL:
>             Project: Apache Camel
>          Issue Type: New Feature
>         Environment: 	<properties>
> 		<camel-version>2.0-SNAPSHOT</camel-version>
> 		<fuse-version>2.x-fuse-SNAPSHOT</fuse-version>
> 		<activemq-version>5.2.0</activemq-version>
> 		<quickfix-version>1.3.3</quickfix-version>
> 		<mina-version>1.1.0</mina-version>
> 		<slf4j-version>1.5.6</slf4j-version>
> 	</properties>
>            Reporter: Charles Moulliard
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.5.0
>         Attachments:, camel-quickfix.patch,,,,
> Hi,
> ATTENTION: Ignoring converter type: org.apache.camel.fix.FixConverter as a dependent
class could not be found: java.lang.NoClassDefFoundError: biz/c24/io/api/data/DataType
> java.lang.NoClassDefFoundError: biz/c24/io/api/data/DataType
> 	at java.lang.Class.getDeclaredMethods0(Native Method)
> 	at java.lang.Class.privateGetDeclaredMethods(
> 	at java.lang.Class.getDeclaredMethods(
> 	at org.apache.camel.impl.converter.AnnotationTypeConverterLoader.loadConverterMethods(
> 	at org.apache.camel.impl.converter.AnnotationTypeConverterLoader.load(
> 	at org.apache.camel.impl.converter.DefaultTypeConverter.checkLoaded(
> 	at org.apache.camel.impl.converter.DefaultTypeConverter.convertTo(
> 	at org.apache.camel.impl.converter.DefaultTypeConverter.convertTo(
> 	at org.apache.camel.util.IntrospectionSupport.convert(
> 	at org.apache.camel.util.IntrospectionSupport.setProperty(
> 	at org.apache.camel.util.IntrospectionSupport.setProperties(
> 	at org.apache.camel.impl.DefaultComponent.setProperties(
> 	at org.apache.camel.component.file.GenericFileComponent.createEndpoint(
> 	at org.apache.camel.component.file.GenericFileComponent.createEndpoint(
> 	at org.apache.camel.impl.DefaultComponent.createEndpoint(
> 	at org.apache.camel.impl.DefaultCamelContext.getEndpoint(
> 	at org.apache.camel.util.CamelContextHelper.getMandatoryEndpoint(
> 	at org.apache.camel.model.RouteType.resolveEndpoint(
> 	at org.apache.camel.impl.DefaultRouteContext.resolveEndpoint(
> 	at org.apache.camel.impl.DefaultRouteContext.resolveEndpoint(
> 	at org.apache.camel.model.FromType.resolveEndpoint(
> 	at org.apache.camel.impl.DefaultRouteContext.getEndpoint(
> 	at org.apache.camel.model.RouteType.addRoutes(
> 	at org.apache.camel.model.RouteType.addRoutes(
> 	at org.apache.camel.impl.DefaultCamelContext.startRouteDefinitions(
> 	at org.apache.camel.impl.DefaultCamelContext.doStart(
> 	at org.apache.camel.spring.SpringCamelContext.maybeDoStart(
> 	at org.apache.camel.spring.SpringCamelContext.doStart(
> 	at org.apache.camel.impl.ServiceSupport.start(
> 	at org.apache.camel.spring.SpringCamelContext.maybeStart(
> 	at org.apache.camel.spring.SpringCamelContext.onApplicationEvent(
> 	at org.springframework.context.event.SimpleApplicationEventMulticaster$
> 	at org.springframework.core.task.SyncTaskExecutor.execute(
> 	at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(
> 	at
> 	at
> 	at
> 	at<init>(
> 	at<init>(
> 	at org.apache.camel.spring.Main.createDefaultApplicationContext(
> 	at org.apache.camel.spring.Main.doStart(
> 	at org.apache.camel.impl.ServiceSupport.start(
> 	at
> 	at
> 	at org.apache.camel.spring.Main.main(
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(
> 	at java.lang.reflect.Method.invoke(
> 	at org.apache.camel.maven.RunMojo$
> 	at
> The org.apache.camel.fix.FixConverter class uses proprietary classes : 
> import;
> import;
> import;
> import;
> import;
> import;
> import;
> import;
> import;
> import;
> import;
> import;
> Except if those classes are part of open source community but How can I use this component
without Artix Data Service ?
> ex config :
> 		<route>
> 			<from uri="fixserver:banzai-to-camel.cfg" />
> 			<to uri="log:quickfix" />
> 		</route>

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message