camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-2734) Camel source jars should support source code attachment feature of eclipse ide in pde mode
Date Wed, 26 May 2010 22:36:52 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=59553#action_59553
] 

Christian Schneider commented on CAMEL-2734:
--------------------------------------------

I think the problem with the source:jar call is that it is outside the normal build lifecycle.
So the initialize phase where the properties are set is not called.
The following call works:
mvn initialize source:jar install

Btw. It is also possible to have the source plugin attach the source.jar to the installed
artifacts everytime install is called. Do you think it would make sense to simply define this?

I have also found a minor problem with the source.jar Manifest we should fix. The Manifest
should also contain a Bundle-Version. Could you add the following line to the <ManifestEntries>:
<Bundle-Version>${camel.osgi.version.clean}</Bundle-Version>


> Camel source jars should support source code attachment feature of eclipse ide in pde
mode
> ------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2734
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2734
>             Project: Apache Camel
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Christian Schneider
>            Assignee: Willem Jiang
>             Fix For: 2.3.0
>
>         Attachments: camel-core-2010-05-20.patch
>
>
> While source attachment works nicely outside of eclipse pde bundles with mvn eclipse:eclipse
the same is currently very difficult when using the pde mode of eclipse. As this mode is the
default for UI design camel should support it.
> I found in the eclips pde FAQ that it is necessary to add a header to the Manifest of
the source bundle to attach it to the bundle. See
> http://wiki.eclipse.org/PDE/FAQ#How_do_source_attachments_for_bundles_work
> For camel-core-2.2.0-sources.jar I added the following to the Manifest by hand:
> Bundle-SymbolicName: org.apache.camel.camel-core.source
> Eclipse-SourceBundle: org.apache.camel.camel-core;version="2.2.0"
> After this simple change the source was automatically attached to the bundle by eclipse.
So I propose to add this header by default to all source artifacts created in the maven build.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message