Return-Path: Delivered-To: apmail-camel-dev-archive@www.apache.org Received: (qmail 47921 invoked from network); 2 Apr 2010 14:13:32 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Apr 2010 14:13:32 -0000 Received: (qmail 49088 invoked by uid 500); 2 Apr 2010 14:13:32 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 49069 invoked by uid 500); 2 Apr 2010 14:13:32 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 49055 invoked by uid 500); 2 Apr 2010 14:13:32 -0000 Delivered-To: apmail-activemq-camel-dev@activemq.apache.org Received: (qmail 49048 invoked by uid 99); 2 Apr 2010 14:13:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Apr 2010 14:13:32 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Apr 2010 14:13:29 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 676DD234C052 for ; Fri, 2 Apr 2010 14:13:08 +0000 (UTC) Message-ID: <2098115205.11521270217588401.JavaMail.jira@brutus.apache.org> Date: Fri, 2 Apr 2010 14:13:08 +0000 (UTC) From: "Jim Talbut (JIRA)" To: camel-dev@activemq.apache.org Subject: [jira] Updated: (CAMEL-2563) The Trace mechanism is inflexible and inefficient - specifically it doesn't enable custom tracing around a node. In-Reply-To: <78257883.18211269005150642.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: ae95407df07c98740808b2ef9da0087c X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/CAMEL-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Talbut updated CAMEL-2563: ------------------------------ Attachment: (was: tracechanges.diff) > The Trace mechanism is inflexible and inefficient - specifically it doesn't enable custom tracing around a node. > ---------------------------------------------------------------------------------------------------------------- > > Key: CAMEL-2563 > URL: https://issues.apache.org/activemq/browse/CAMEL-2563 > Project: Apache Camel > Issue Type: Improvement > Components: camel-core > Affects Versions: 2.3.0 > Environment: All. > Reporter: Jim Talbut > Priority: Minor > Fix For: Future > > Attachments: tracechanges.diff, tracechanges.diff, tracechanges.diff > > Original Estimate: 2 days > Remaining Estimate: 2 days > > What it won't let me do: > I want to be able to correlate the "out" trace with the "in" trace, in one database row without commiting the row until the route has completed. > This requires a JPA transaction to exist around each of the nodes that are called. > I'm finding that the transaction has ended by the time of the "out" trace. > Inefficiencies: > 1. It causes the construction of the new Exchange object and a bunch of String objects that I don't want. > 2. It causes the invocation of a new route, that is unnecessary. > I think it would be better to: > 1. Pass the class to use as the TraceInterceptor into Tracer. > 2. Break the existing TraceInterceptor into two, a base class that tracks the RouteNodes and a subclass that implements traceExchange. > 3. Change traceExchange so that it returns an Object and pass that Object in to the call to traceExchange for "out" traces. > 4. Give the Tracer a payload object that can be used to pass information to the TraceInterceptor. > 5. Change the various trace* functions to take in and return a payload Object. > Custom users could then dervice from TraceInterceptor and override the trace* functions as necessary (probably just traceExchange). > I'm working on a patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.