camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-2631) Add time millis converter which can convert from String to long
Date Wed, 21 Apr 2010 08:05:16 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58999#action_58999
] 

Claus Ibsen commented on CAMEL-2631:
------------------------------------

Ah I was a bit misleading.

The Void.TYPE thingy only applies for @FallbackTypeConverters, where you can indicate that
you do not know how to convert that particular type mapping combo.

So in our case as its a real type converter you HAVE to convert to a long to be returned.
So if you get "444" as input, then output should be a 444 long value.
This is missing. 

And add a test for that also.


On a side note. I wonder if we should allow different abbreviations
- h | H | hour | Hour | hours | Hours
- m | M | min | Min | minute | Minute | minutes | Minutes
- s | S | sec | Sec | second | Second | seconds | Seconds

Maybe it improves readability
{code}
3hours2minutes1second
15sec
5min
4min2sec
{code}

> Add time millis converter which can convert from String to long
> ---------------------------------------------------------------
>
>                 Key: CAMEL-2631
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2631
>             Project: Apache Camel
>          Issue Type: New Feature
>          Components: camel-core
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>            Priority: Minor
>         Attachments: time-pattern-converter-patch2.diff
>
>
> Its currently a bit annoying to set a delay by millis and if you need, like 1 hour 30
min period. What is this in millis?
> We should add a TypeConverter for that which has a String notation such as:
> {code}
> 1h30m
> 3h45m25s
> 10m
> 15m20s
> 30s
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message