camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-2371) Netty component
Date Thu, 04 Mar 2010 16:39:44 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58041#action_58041
] 

Claus Ibsen commented on CAMEL-2371:
------------------------------------

Cool work, just a few comments

You pass in a thread pool to Netty in NettyConsumer
{code}
 new NioServerSocketChannelFactory(Executors.newCachedThreadPool(), Executors.newCachedThreadPool());
{code}

You can use the org.apache.camel.util.ExecutorServices which offer a newCachedThreadPool where
you can pass in a thread name.
This is good to use as then the threads will be prefixed with Camel and a counter which ensures
that end users can know its from Camel.
You can etc. use the endpointUri as the thread name

Btw in your unit tests you can avoid ugly type casting and pass in the type as 2nd parameter.
{code}
String reply requestBody("direct:foo", "hello", String.class);
{code}

Maybe you can add a little DEBUG or INFO logging when the consumer starts so it logs which
host:port it starts to listen.

What does this annotation do?
{code}
+@ChannelPipelineCoverage("all")
{code}

And in the exceptionCaught method its debugged that the channel is closed, but there is no
code that does this, is this correct?

In ServerChannelHandler you convert the payload from byte[] -> String if DEBUG logging
is enable. If DEBUG is not enable you do NOT convert. This is wrong.


> Netty component
> ---------------
>
>                 Key: CAMEL-2371
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2371
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: Future
>
>         Attachments: camel-netty-patch.diff, camel-netty20100304.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement
to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still
not released. 
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It
appears as a good alternative.
> Netty is also Apache licensed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message