camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <>
Subject [jira] Commented: (CAMEL-2371) Netty component
Date Sat, 20 Mar 2010 12:23:45 GMT


Claus Ibsen commented on CAMEL-2371:

- The INFO logging has a bit of space and colon cosmetic issue
- The source parameter for creating thread pool from Camel should be {{this}} and not {{null}}
- Why is the UDP mode using a CachedThreadPool and not using size/maxSize from configuration
as with TCP?
- The thread pool name is too long, as it should just be like: {{NettyTCPBoss}} or {{NettyTCPWorker}}
etc. Camel will add more details to the thread name as well.

- I wonder if just logging the Exception is enough? And when logging you should add the exception
as 2nd parameter so we got the stacktrace also

- The WARN logging may have some English wording issue.

- In the doStart you init either UDP or TCP. I think the if should be an if else to make this
more strong. Having a {{return}} is not nice.
- Doesn't the await method on {{countdownLatch.await}} return a boolean if the timeout triggered,
if so please use that instead of checking for == 1 as you currently do.
- I think the bufferSizes should be configurable as well, currently they are hardcoded

- Please check methods as some have empty lines in it, and there are like double lines between
methods. Just to keep the code nice and clean

> Netty component
> ---------------
>                 Key: CAMEL-2371
>                 URL:
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: Future
>         Attachments: camel-netty-patch.diff,, camel-netty20100316.diff,
> Consider creating a new JBoss [Netty|] component as a supplement
to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still
not released. 
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It
appears as a good alternative.
> Netty is also Apache licensed.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message