camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-2371) Netty component
Date Thu, 25 Mar 2010 06:23:08 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58443#action_58443
] 

Claus Ibsen commented on CAMEL-2371:
------------------------------------

Cool.

I could on find a missing space in these INFO logs, which there are in multiple source files
{code}
  LOG.info("Netty TCP Consumer started and now listening on Host: " + configuration.getHost()
+ "Port: " + configuration.getPort());
{code}

Notice there is no space before {{Port:}}


And in this code
{code}
  if (!future.isSuccess()) {
+            throw new CamelExchangeException("Could not send response via Channel", exchange);
+        }
{code}

Maybe you can dig more info from Netty's {{MessageEvent}} so you can add more details to the
exception. For example the host:port where you was trying to write etc.


And is the {{clean}} plugin needed in the {{pom.xml}} file? Maybe you copied it from camel-ftp
which uses it?

> Netty component
> ---------------
>
>                 Key: CAMEL-2371
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2371
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Claus Ibsen
>            Assignee: Ashwin Karpe
>             Fix For: Future
>
>         Attachments: camel-netty20100316.diff, camel-netty20100316.zip, camel-netty20100324.diff,
camel-netty20100324.zip
>
>
> Consider creating a new JBoss [Netty|http://www.jboss.org/netty/] component as a supplement
to the MINA component.
> It starts to become a _joke_ with the Mina 2.0 release which has take 2+ years and still
not released. 
> And one of the primary drivers behind MINA joined JBoss and created Netty instead. It
appears as a good alternative.
> Netty is also Apache licensed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message