camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Genender (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-2445) BatchProcesser.processExchange needs to catch Throwable
Date Thu, 04 Feb 2010 00:02:32 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=57361#action_57361
] 

Jeff Genender commented on CAMEL-2445:
--------------------------------------

This is caused by the the trapping of Exception in the BatchSender but wont fire for Throwable
(i.e. NoSuchMethodError/LingageError, etc).  Thus when the exceptions fire, it continues on
about its way, filling the LinkedList and thus a memory leak ensues.  The patch really should
be at where it is already looking for errors.  Patches for 1.x and 2.x. are attached.

> BatchProcesser.processExchange needs to catch Throwable
> -------------------------------------------------------
>
>                 Key: CAMEL-2445
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2445
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.6.2, 2.1.0
>            Reporter: Stan Lewis
>            Assignee: Stan Lewis
>             Fix For: 1.6.3, 2.2.0
>
>         Attachments: patch-1.x.txt, patch-2.x.txt
>
>
> If an aggregator sends an exchange to a processor that throws an Error this causes the
thread started by BatchProcessor to exit, exchanges will then accumulate in the aggregator
until an OutOfMemoryError occurs.
> This patch sorts that out and adds a unit test, however there's another problem that
I'm still looking into, namely that BatchProcessor just uses an instance of LoggingErrorHandler
as it's exception handler, so any exceptions/errors caught by this processor will just get
logged and not follow the normal Camel error handling.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message