camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William Tam (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-2345) One should not have to explicitly provide the service/port for cxf is there's only one
Date Wed, 13 Jan 2010 14:51:44 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56887#action_56887
] 

William Tam commented on CAMEL-2345:
------------------------------------

Yea, it looks like we can relax this requirement for client but NOT for the server as ServerFactoryBean
fails to initialize without serviceName and portName (if serviceClass is not specified. i.e.
wsdl only).   I think it is a best practice to provide serviceName and portName for wsdl only
use case but I agree that they are not required on the client (producer).  We probably should
update CXFWsdlOnlyPayloadModeNoSpringTest and CXFWsdlOnlyMessageModeNoSpringTest if we do
change it.  And update the notes in the serviceClass option about this requirement in the
http://cwiki.apache.org/confluence/display/CAMEL/CXF.  Let me know if you want me to handle
it.  thx.




> One should not have to explicitly provide the service/port for cxf is there's only one
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2345
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2345
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-cxf
>    Affects Versions: 2.1.0
>            Reporter: Hadrian Zbarcea
>            Assignee: Hadrian Zbarcea
>
> This is due to the following code in {{Client createClient()}} in {{CxfEnpoint}}
> {code}
>         } else {
>             ObjectHelper.notNull(portName, "Please provide endpoint/port name");
>             ObjectHelper.notNull(serviceName, "Please provide service name");
>             ClientFactoryBean factoryBean = createClientFactoryBean();
> {code}
> When there's only one service/port, we should just use it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message