Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Message-ID: <373322668.1256587853049.JavaMail.jira@brutus>
Date: Mon, 26 Oct 2009 13:10:53 -0700 (PDT)
From: "Claus Ibsen (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Commented: (CAMEL-2102) Transacted routes don't allow custom
 error handlers to mark exception as handled AND set rollback only
In-Reply-To: <510061971.1256246152693.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/activemq/browse/CAMEL-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=54986#action_54986 ] 

Claus Ibsen commented on CAMEL-2102:
------------------------------------

Its fine I used the new markRollbackOnly.

Can you test the new code on your system?

And if you have an unit test that you think is good to add then you can attach it.
You can check the unit tests I added by the commit log and the new added tests from the source. 

> Transacted routes don't allow custom error handlers to mark exception as handled AND set rollback only
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-2102
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-2102
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-spring
>    Affects Versions: 2.0.0
>         Environment: All platforms
>            Reporter: Dhiraj Bokde
>            Assignee: Claus Ibsen
>             Fix For: 2.1.0
>
>         Attachments: camel-spring-patch.txt
>
>
> If a route is transacted using transacted(), and a custom error handler is registered using onException() which handles the exception using handled(), creates a custom error response, and marks the transaction to be rolled back using rollback(), Camel wraps a non-existent 'null' exception with a TransactedRuntimeCamelException in TransactionErrorHandler.wrapTransactedRuntimeException() and throws the TRCE, causing the custom error response to be ignored. 
> Route looks like:
> 		// configure error handler for all routes
> 		onException(Exception.class).handled(true).to("bean:transformerBean?method=exceptionToResponse").rollback();
> 		from("cxfrs://bean:categoriesEndpoint").transacted()
> 			.choice()...
> Basically the application wants to handle exceptions by sending a custom error message back to the route client, and also mark transactions for rollback. 
> Attached patch checks for the presence of an exception, and only raises a TRCE if its not null. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.