Return-Path: Delivered-To: apmail-camel-dev-archive@www.apache.org Received: (qmail 36106 invoked from network); 27 Oct 2009 23:04:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Oct 2009 23:04:16 -0000 Received: (qmail 82878 invoked by uid 500); 27 Oct 2009 20:14:15 -0000 Delivered-To: apmail-camel-dev-archive@camel.apache.org Received: (qmail 82826 invoked by uid 500); 27 Oct 2009 20:14:15 -0000 Mailing-List: contact dev-help@camel.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@camel.apache.org Delivered-To: mailing list dev@camel.apache.org Received: (qmail 82761 invoked by uid 500); 27 Oct 2009 20:14:15 -0000 Delivered-To: apmail-activemq-camel-dev@activemq.apache.org Received: (qmail 82742 invoked by uid 99); 27 Oct 2009 20:14:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 20:14:15 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2009 20:14:13 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 1AC78234C1F1 for ; Tue, 27 Oct 2009 13:13:53 -0700 (PDT) Message-ID: <1042946216.1256674433106.JavaMail.jira@brutus> Date: Tue, 27 Oct 2009 13:13:53 -0700 (PDT) From: "Claus Ibsen (JIRA)" To: camel-dev@activemq.apache.org Subject: [jira] Updated: (CAMEL-1698) Break out the smack listeners implemented by XmppConsumer out to separate classes, and add a ConnectionListener. In-Reply-To: <1110350454.1244742695324.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: ae95407df07c98740808b2ef9da0087c [ https://issues.apache.org/activemq/browse/CAMEL-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-1698: ------------------------------- Fix Version/s: 2.2.0 > Break out the smack listeners implemented by XmppConsumer out to separate classes, and add a ConnectionListener. > ---------------------------------------------------------------------------------------------------------------- > > Key: CAMEL-1698 > URL: https://issues.apache.org/activemq/browse/CAMEL-1698 > Project: Apache Camel > Issue Type: Improvement > Components: camel-xmpp > Affects Versions: 2.0-M1 > Reporter: Edward Campbell > Assignee: Stan Lewis > Fix For: 2.2.0 > > > According to the smack documentation if you register the same listener multiple times, only the most recent filter is used. > Since the XmppConsumer is being used for all listeners in this case only the last addListener call is honored. > It would be wiser to have the listeners as separate classes, then the handling of each packet/message type can be addressed separately. > A ConnectionListener can be added as well to handle connections that go down and can be retried later. > Proposed listeners: > ConnectionListener (to listen to and respond to connection and disconnection events) > MessageListener (to listen to and process messages) > RosterListener (to listen to and process roster events) > PresenceListeners (should be one for most types of listener defined in org.jivesoftware.smack.packet) > Each listener type should be able to pass messages up through the camel exchange. All except the MessageListener should be disabled by default, but enabled via an option in the uri passed to camel. MessageListener should always pass the message up through the camel exchange. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.