Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Message-ID: <2029648607.1246646167129.JavaMail.jira@brutus>
Date: Fri, 3 Jul 2009 11:36:07 -0700 (PDT)
From: "Jonathan Anstey (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Commented: (CAMEL-1392) groovy renderer
In-Reply-To: <1908239513.1235639520155.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/activemq/browse/CAMEL-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52686#action_52686 ] 

Jonathan Anstey commented on CAMEL-1392:
----------------------------------------

Quickly trying this new code drop out before leaving for the day :) In the GroovyRendererTest I noticed pretty much all routes defined in the supported list get rendered like "from("direct:start",).to("mock:result")". Example output:

{code}
dsl: from("direct:start").unmarshal().serialization().to("mock:result")
after rendered: 
import org.apache.camel.language.groovy.GroovyRouteBuilder;
class GroovyRoute extends GroovyRouteBuilder {
void configure() {
from("direct:start",).to("mock:result")
}
}
{code}

Not sure if this is a bug in the renderer or the test case. Care to fix that up?

Also unit tests typically contain assertions on the output of a piece of code to make sure its operating correctly. In your case the test should be asserting that the output of the renderer is correct. Currently we have to verify this by looking at the output.

> groovy renderer
> ---------------
>
>                 Key: CAMEL-1392
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1392
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Xueqiang Mi
>         Attachments: camel-web-20090629.patch, camel-web-20090703.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.