camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alloyer <>
Subject Re: How can I do the -Psourcecheck before creating a patch?
Date Mon, 29 Jun 2009 10:17:45 GMT seems i used it uncorrectly before. the checkstyle pluging works well
on every unproper formattings.

alloyer wrote:
> Yes, the checkstyle plugin provides most of the proper code style.
> But there are some ill-suited code checkstyle plugin can not detect, like
> this,
>  @Produces( {XXX})
>  the checkstyle can not notice a whitespace is added after the "("
> uncorrectly. eclipse will add it when formatting operation by default, so
> the mvn command is better for me although it cost a little more time.
> Thanks, 
> willem.jiang wrote:
>> Hi,
>> Do you use eclipse to edit your camel code?
>> I just did some improvement on the eclipse checkstyle setting up. Please
>> feel free to give it a try :)
>> 1. Install the checkstyle pulgin for eclipse
>> 2. Setup the workspace for the checkstyle
>>   * Build the kit first
>>      mvn clean install -Dtest=false
>>   * Set up the workspace with checkstyle setting
>>      mvn eclipse:eclipse -Psetup.eclipse
>>   * You will find the mvn create a wrokspace directory in the parent
>> directory of the camel trunk directory.
>>     Open the eclipse and use the wrokspace, then import the projects
>> from the camel trunk.
>> In this way you could see if the code is ok for checkstyle in eclipse.
>> Willem
>> alloyer wrote:
>>> Hi, can anyone tell me how to add option -Psourcecheck when creating a
>>> patch?
>>> My previous patch have some style problem and jonstey tell me to do
>>> source
>>> check to ensure proper formatting  when building the patch, but I can
>>> not
>>> find how to do it. I am using TortoiseSVN  on windows XP.

View this message in context:
Sent from the Camel Development mailing list archive at

View raw message