Mailing-List: contact dev-help@camel.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@camel.apache.org
Message-ID: <363947950.1240936058141.JavaMail.jira@brutus>
Date: Tue, 28 Apr 2009 09:27:38 -0700 (PDT)
From: "Claus Ibsen (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Commented: (CAMEL-1563) Message - getOut, getFault should
 not create empty message if none exists
In-Reply-To: <1890042062.1240552178069.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/activemq/browse/CAMEL-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51425#action_51425 ] 

Claus Ibsen commented on CAMEL-1563:
------------------------------------

What if we add:
- {getOrCreateOut}
- {getOrCreateFault}

Wouldn't that help understand the problem and migrate to a getOut that can return {null} if no out exists. So the newbie problem that Roman highlighted can be avoided. Its sure is hard to find the lost header or body if you added some system out for a little logging.

The big concern would be if the change would break to much for existing users doing upgrades.

What does the community think?

> Message - getOut, getFault should not create empty message if none exists
> -------------------------------------------------------------------------
>
>                 Key: CAMEL-1563
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1563
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.0-M1
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0
>
>
> The getOut and getFault methods on org.apache.camel.Message creates a new empty object if none exists already.
> This confuses end users when they use the methods in their custom processors.
> We should instead add hasOut, hasFault methods that can be used for checking if it exists or not.
> *Note:* The getOut(false) can be used to not create a new message if none exists but its really not adhering to good java beans standard.
> See nabble:
> http://www.nabble.com/Payload-Gets-Nulled-Out-td23105477.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.