camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-1461) A request route with a topic node incurs a 20 second wait and refers to the wrong MEP.
Date Sun, 05 Apr 2009 07:13:34 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=51031#action_51031
] 

Claus Ibsen commented on CAMEL-1461:
------------------------------------

Marat,

> Yes I did manage to get all of the tests to pass before I restarted this thread, but
as you said my use case is now quite cumbersome and I think it really does not have to be.
Did you try the option I suggested?


> Please take a look at the patch attached. I think this will keep all happy.
Thanks a lot for the patch and that you kept pushing your views. And not the least had the
patience to explain it in details so I could understand it :)

I have applied the patch:
trunk: 762047
1.x: 762050


> The usual use case for topics are one way messages, so if the user really wants to reply
to destination that came with a message received over a topic then the receiver
> should be ready to accept more than one reply correlated on the same source message.

Agree

> Since a request/reply pattern is 1 request 1 reply, then the reply destination embedded
in the message
> that came over a topic should really be decoupled from the destination used to receive
a reply from request/reply pattern.
Agree if you by decoupled mean the original request/reply pattern - eg the original caller
JMSReplyTo should be decoupled from the JMSReplyTo that came over the topic. 



> A request route with a topic node incurs a 20 second wait and refers to the wrong MEP.
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-1461
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1461
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-jms
>    Affects Versions: 1.6.0
>         Environment: ActiveMQ/Camel
>            Reporter: Michael Chen
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0, 1.6.1
>
>         Attachments: CAMEL-1461-2009-04-05-01-58.patch
>
>
> If a route contains a node that publishes to a topic, the route is incorrectly suspended
for a default 20 seconds at the topic node.  Further, JmsProducer.java checks the MEP of the
original request Exchange and not the endpoint of the topic.
> For example, say I have a route built like this:
> {code}
> from("activemq:queue:request").
>   to("generate_news").
>   to("activemq:topic:news").
>   to("do_something_else");
> {code}
> The original request is expecting a reply. However, after the "news" is pumped into the
news topic, there is a default 20 second wait (requestTimeout).  This wait always results
in the exception: "The OUT message was not received within: 20000 millis on the exchange..."

> After reading the JmsProducer code, I changed the route to the following:
> {code}
> from("activemq:queue:request").
>   to("generate_news").
>   to("activemq:topic:news?exchangePattern=InOnly").
>   to("do_something_else");
> {code}
> This reveals the root of the bug, which is in the first few lines of method org.apache.camel.component.jms.JmsProducer.process(Exchange):
> {code}//
>     public void process(final Exchange exchange) {
>         final org.apache.camel.Message in = exchange.getIn();
>         if (exchange.getPattern().isOutCapable()) {
> {code}
> The above if statement checks the MEP of the original request's Exchange and not the
new endpoint of the news topic. This makes the above "?exchangePattern=InOnly" configuration
useless, because the original request MEP is InOut.  The result is that after that 20 second
time-out, the temporary queue for the original request has expired, so the whole request failed.
Note that the next node "do_something_else" is never reached due to the time-out exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message