Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: camel-dev@activemq.apache.org
Received-SPF: pass (nike.apache.org: domain of willem.jiang@gmail.com
 designates 209.85.142.184 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:x-enigmail-version:content-type
         :content-transfer-encoding;
        b=elIJMtg8NG33S6fzACyQVPisYNUd6BfLjF+ovzSj8AQlvpj23dqcc46KjKPN3SVYLT
         6kkbinByRrarfv7+fbiAlIHojpCZXnHcIlggPDBxKJqNeAR5bLKSMVOM1OyrCNj2uqHZ
         pKi2LeFacdOP5BtFFjpqFPvCSwaStRgQD2Ub0=
Message-ID: <4966B9B3.6030705@gmail.com>
Date: Fri, 09 Jan 2009 10:42:59 +0800
From: Willem Jiang <willem.jiang@gmail.com>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: camel-dev@activemq.apache.org
Subject: Re: Quick questions in CxfConsumer code
References: <eeacbf0c0901081246x32dc52n13d15c034a9df9a0@mail.gmail.com>
In-Reply-To: <eeacbf0c0901081246x32dc52n13d15c034a9df9a0@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi,

Please see my comments in the mail.
William Tam wrote:
> In doing code cleanup in camel-cxf, I come across a question.  In the
> constructor of CxfConsumer, it tries to assign value to the variable
> bus.  The bus will be used later on to setBus on
> 
>         Bus bus = null;
>         this.endpoint = endpoint;
>         boolean isWebServiceProvider = false;
>         if (endpoint.getApplicationContext() != null) {
>             SpringBusFactory bf = new
> SpringBusFactory(endpoint.getApplicationContext());
>             bus = bf.createBus();
>             if (CxfEndpointUtils.getSetDefaultBus(endpoint)) {
>                 BusFactory.setDefaultBus(bus);
>             }
>         } else {
>             // now we just use the default bus here
>             bus = BusFactory.getDefaultBus();
>         }
>         ServerFactoryBean svrBean = null;
>         ...
>         svrBean.setBus(bus);
> 
> Questions:
> 1) Is the setDefaultBus option only applied to non-Spring CxfEndpoint?
BusFactory.getDefaultBus() will call set the setDefaultBus , if there is
a new bus created.
if (CxfEndpointUtils.getSetDefaultBus(endpoint)) {
    BusFactory.setDefaultBus(bus);
}
This code just helps other CXF components to share the bus with the
Spring camel-cxf endpoint.
> 2) If I add a feature to lookup a bus from the registry/application
> context for non-Spring CxfEndpoint, I would set svrBean to the my bus
> (from the registry) and not getting the default bus.  In this case,
> setDefaultBus option would make sense to non-Spring CxfEndpoint as
> well, right?  And, it means setting my bus as default.
Yes, you may have more than one bus in the registry (which set up by
spring). We should let the use to configure the bus for the no-spring
endpoint. How about add a parameter like the busId in the cxf uri ?
> 3) For Spring CxfEndpoint, does bf.createBus() return the same bus as
> CxfEndpointBean.getBus()?  I guess it may or may not.  You could
> define a bus just for your endpoint, right.  So, would it better to
> take the one from the endpoint bean?
Good question, the original thought of the code is pass the spring
context into the bus. But I think we could update the code to inject the
Application context into the bus which is used by endpoint.
> 
> Thanks,
> William
> 

Cheers,

Willem