camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Strachan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-1213) camel-jms consumer does not set camel message id based on JMS message id if the next node is not JMS based
Date Mon, 05 Jan 2009 18:41:05 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48477#action_48477
] 

James Strachan commented on CAMEL-1213:
---------------------------------------

bad James! :)

> camel-jms consumer does not set camel message id based on JMS message id if the next
node is not JMS based
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-1213
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1213
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-jms
>    Affects Versions: 1.5.0
>            Reporter: Claus Ibsen
>            Assignee: Claus Ibsen
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: CAMEL-1213.patch
>
>
> The code in org.apache.camel.component.jms.copyFrom looks odd
> I think the ! should be removed
> BEFORE
> {code}
>         if (!copyMessageId) {
>             setMessageId(that.getMessageId());
>         }
> {code}
> AFTER
> {code}
>         if (copyMessageId) {
>             setMessageId(that.getMessageId());
>         }
> {code}
> I will add a unit test (JmsToFileMessageIdTest) based on end user having some trouble
with it

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message