camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <>
Subject [jira] Commented: (CAMEL-398) Map the content of a CSV file to a POJO using @annotation and .convertBodyTo()
Date Tue, 20 Jan 2009 12:48:00 GMT


Claus Ibsen commented on CAMEL-398:

Comments on first impression

- interfaces should always be fully javadoced (especially if others should use or implement
- the classloading should be changed to use Camel classes and be OSGi friendly
- dependency on camel-spring should only be scope for test (= unit testing)
- Would it not be nice that each POJO should be annoted at classlevel as well (
does not have etc.)
- Why are the fields in the model objects public? We should support private fields and use
getter/setter to access them
- LinkType? Doesnt hibernate have a similar feature and maybe there is a better name?
- ModelFactory if its a shared instance then it need locking for concurrent access (we can
address this later)
- BindyDataFormat might be renamed to BindyCsvDataFormat (its nice when the classname has
this important piece in its name)
- use Camel type converter to convert from String to byte[] as it will handle encoding as
well (exch.getContext().getTypeConverter().convertTo(byte[].class, exch, exch);) in BindyDataFormat
- In unmarshal we should use a java.util.Scanner if we for instance is reading a very big
file and can reduce memory usage
- code needs to be polished a bit. If you use IDEA it reports :) Well we get that later
- ModelFactory should probably have an interface and a DefaultModelFactory implementatiion
- format.impl is not a nice package name - just use format
- I dont think you should use threadlocal to store pattern formatters. Yes they are not thread
safe (damm SUN). creating objects is not expensive anymore!
- ByteFormat - new Byte(String) is not the right one to use - use parseByte instead. 
- We could probably use generics for the format, so the API is nicer (we can check that later)

> Map the content of a CSV file to a POJO using @annotation and .convertBodyTo()
> ------------------------------------------------------------------------------
>                 Key: CAMEL-398
>                 URL:
>             Project: Apache Camel
>          Issue Type: New Feature
>          Components: camel-core
>    Affects Versions: 1.4.0
>            Reporter: Charles Moulliard
>            Assignee: Claus Ibsen
>             Fix For: 2.0.0
>         Attachments:
> Hi,
> It should be nice if in a next relase of Camel, it will be possible to map the content
of a CSV file to a POJO using @annotation.
> For the moment, I use an ArrayList + iterator (see code hereafter) to achieve the extraction
of the content but I'm sure that we can simplify this code using @Annotation
> and the following action (.convertBodyTo(Order<List>) by example.
> Current situation
> Camel route
> from("file:///c:/temp/test?noop=true")
> .unmarshal().csv()
> .to("bean:converter?methodName=TransformMessage"); --> should be replaced by something
like .convertBodyTo(Order<List>)
> Converter class
>         public void TransformMessage(Exchange in) {
>                 process(in.getIn().getBody(List.class));
>         }
>         @SuppressWarnings("unchecked")
>         private void process(List messages) {
>                 // Iterate through the list of messages
>                 for (Iterator<ArrayList> it = messages.iterator(); it.hasNext();)
>                         // Split the content of the message into field
>                         message =;
>                         field = (String[]) message.toArray();
>                         order = new Order();
>                         order.setId(Integer.valueOf(field[0]).intValue());
>                         order.setBank(field[1]);
>                         order.setAmountFrom(Double.parseDouble(field[2]));
>                         order.setAmountTo(Double.parseDouble(field[3]));
>                         order.setOrderInstruction(field[4].trim());
>                         this.orderService.createOrder(order);
>                 }
>         }
> Regards,
> Charles

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message