Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: camel-dev@activemq.apache.org
Received-SPF: pass (nike.apache.org: domain of claus.ibsen@gmail.com
 designates 74.125.92.144 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=X3/Th8XKMJuod0Tm9HF7DgclpY7Lvof1Sgmu0BEDLHyJzQ7eV0vY2NHjYUt4/5bRPF
         dCKxKeCidip8mdzmIGZNZrMw7Wwwfw6d9yPJnGRM760vomENTVmhsxYtol1KygEzRQWX
         N5fAd+P8Wicr1UaP8lNG1CM4fa1rmWwOO8qKw=
Message-ID: <5380c69c0812172214h2df64308l86b8baedcea79c49@mail.gmail.com>
Date: Thu, 18 Dec 2008 07:14:09 +0100
From: "Claus Ibsen" <claus.ibsen@gmail.com>
To: camel-dev@activemq.apache.org
Subject: Re: MockEndpoint - sleep for empty tests is flawed?
In-Reply-To: <5380c69c0812172146v2d3b0562n14d04643578e4dd5@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <5380c69c0812172146v2d3b0562n14d04643578e4dd5@mail.gmail.com>

I created a ticket for it
https://issues.apache.org/activemq/browse/CAMEL-1196

And attached a better patch. Runs fine now. all core tests passes.

On Thu, Dec 18, 2008 at 6:46 AM, Claus Ibsen <claus.ibsen@gmail.com> wrote:
> Hi
>
> Is there a flaw in MockEndpoint with sleep for empty tests?
> For instance if I have this code I would expect it to wait 10 sec
> before stopping, but it doesn't.
>
>    public void testManually() throws Exception {
>        deleteDirectory("./target/exclusiveread");
>        MockEndpoint mock = getMockEndpoint("mock:result");
>        mock.setSleepForEmptyTest(10000);
>        mock.expectedMessageCount(0);
>
>        mock.assertIsSatisfied();
>    }
>
>
> Fixing the code in MockEndpoint to this seems to fix it, and it's a
> bit more readable, what it does
>
>
>
>
>    public void assertIsSatisfied(long timeoutForEmptyEndpoints)
> throws InterruptedException {
>        LOG.info("Asserting: " + this + " is satisfied");
>        if (expectedCount == 0) {
>            if (timeoutForEmptyEndpoints > 0) {
>                LOG.debug("Sleeping for: " + timeoutForEmptyEndpoints
> + " millis to check there really are no messages received");
>                Thread.sleep(timeoutForEmptyEndpoints);
>            } else {
>                waitForCompleteLatch();
>            }
>            assertEquals("Received message count", expectedCount,
> getReceivedCounter());
>        } else if (expectedCount > 0) {
>            if (expectedCount != getReceivedCounter()) {
>                waitForCompleteLatch();
>            }
>            assertEquals("Received message count", expectedCount,
> getReceivedCounter());
>        } else if (expectedMinimumCount > 0 && getReceivedCounter() <
> expectedMinimumCount) {
>            waitForCompleteLatch();
>        }
>
>
> Feedback from other riders is welcome ;)
>
> --
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>


-- 

/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/