Return-Path: 
 <camel-dev-return-8058-apmail-activemq-camel-dev-archive=activemq.apache.org@activemq.apache.org>
Delivered-To: apmail-activemq-camel-dev-archive@locus.apache.org
Received: (qmail 73986 invoked from network); 15 Dec 2008 18:19:26 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 15 Dec 2008 18:19:26 -0000
Received: (qmail 4056 invoked by uid 500); 15 Dec 2008 18:19:39 -0000
Delivered-To: apmail-activemq-camel-dev-archive@activemq.apache.org
Received: (qmail 3974 invoked by uid 500); 15 Dec 2008 18:19:38 -0000
Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:camel-dev-help@activemq.apache.org>
List-Unsubscribe: <mailto:camel-dev-unsubscribe@activemq.apache.org>
List-Post: <mailto:camel-dev@activemq.apache.org>
List-Id: <camel-dev.activemq.apache.org>
Reply-To: camel-dev@activemq.apache.org
Delivered-To: mailing list camel-dev@activemq.apache.org
Received: (qmail 3962 invoked by uid 99); 15 Dec 2008 18:19:38 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Dec 2008 10:19:38 -0800
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Dec 2008 18:19:25 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 6C157234C3D9
	for <camel-dev@activemq.apache.org>; Mon, 15 Dec 2008 10:19:05 -0800 (PST)
Message-ID: <1752692116.1229365145440.JavaMail.jira@brutus>
Date: Mon, 15 Dec 2008 10:19:05 -0800 (PST)
From: "Claus Ibsen (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Commented: (CAMEL-1159) Check the logic in
 Aggregator.isBatchCompleted()
In-Reply-To: <1003399899.1228801325399.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/activemq/browse/CAMEL-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48189#action_48189 ] 

Claus Ibsen commented on CAMEL-1159:
------------------------------------

William nice patch.

I was wondering if the out batch sample using
- in batch size = 1
- out batch size = 10

<aggregate strategyRef="myAggregatorStrategy" batchSize="1" outBatchSize="10">

Why is the in batch at 1? Is it intended. Can it be removed, so you can choose which batch size you want to use
- IN (number of exchanges) received
- OUT (number of exchanges) to send

So I think a more common use case would be having higher IN batch size than OUT. If that is the fact I think we should change the sample to reflect this. There is also a Java DSL sample.

Minor spelling
// out batch is disable, so go ahead and send.
It should be *disabled*

> Check the logic in Aggregator.isBatchCompleted()
> ------------------------------------------------
>
>                 Key: CAMEL-1159
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1159
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core
>            Reporter: William Tam
>            Assignee: William Tam
>             Fix For: 2.0.0
>
>         Attachments: CAMEL-1159.patch
>
>
> Understand the logic of this method and also see if the protected method getCollection() is really needed (or getCollectionSize() is suffice).  The reason being supporting the getCollection() method may constraint the BatchProcessor class to implement less efficient algorithm.
> {code}
>     @Override
>     protected boolean isBatchCompleted(int index) {
>         if (aggregationCompletedPredicate != null) {
>             // TODO: (davsclaus) What is the point with this code? I think its wrong
>             if (getCollection().size() > 0) {
>                 return true;
>             }
>         }
>         return super.isBatchCompleted(index);
>     }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.