Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: camel-dev@activemq.apache.org
Message-ID: <1490991115.1229010305389.JavaMail.jira@brutus>
Date: Thu, 11 Dec 2008 07:45:05 -0800 (PST)
From: "Jonathan Anstey (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Commented: (CAMEL-1184) Add a new Dataformat - tidyMarkup -
 which allows us to unmarshal bad HTML to good (XML) Html.
In-Reply-To: <1151556144.1229002985469.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/activemq/browse/CAMEL-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48111#action_48111 ] 

Jonathan Anstey commented on CAMEL-1184:
----------------------------------------

I've committed your patch in rev 725715. Thanks again!

Some minor changes I made:
- Checkstyle errors
- Added dataformat to UnmarshalType + test case for this (TidyMarkupDataFormatWithUnmarshalTypeTest.java)
- Added OSGi exports
- Removed runtime dependency on camel-spring - you only need camel-core
- Added log4j config file
- Change to TidyMarkupDataFormat.java
{code}
    public Object unmarshal(Exchange exchange, InputStream inputStream) throws Exception {

        if (dataObjectType.isAssignableFrom(String.class)) {
            return asStringTidyMarkup(inputStream);
        } else if (dataObjectType.isAssignableFrom(Node.class)) {
-            return asStringTidyMarkup(inputStream);
+            return asNodeTidyMarkup(inputStream);
        } else {
            throw new CamelException("The return type [" + dataObjectType.getCanonicalName() + "] is unsupported");
        }
    }
{code}

> Add a new Dataformat - tidyMarkup - which allows us to unmarshal bad HTML to good (XML) Html.
> ---------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-1184
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1184
>             Project: Apache Camel
>          Issue Type: New Feature
>            Reporter: Ramon Buckland
>            Assignee: Ramon Buckland
>            Priority: Minor
>             Fix For: 1.5.1, 2.0.0
>
>         Attachments: tidyMarkup-sourcefiles.tgz
>
>   Original Estimate: 4 hours
>  Remaining Estimate: 4 hours
>
> Using TagSoup, a competent 'bad html' to good well formed (xml) Html, we can create a new dataformat such that ..
>    from("direct:fromSomeHttpSite")
>        .unmarshal().tidyMarkup()
>        .setBody().xpath("//table/tr/td[1]")
>    .to("direct:foo")
> we get to turn the nasty HTML into goody HTML which can go through XSLT components and be xpathed and all the goodness we love.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.