camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Willem Jiang <willem.ji...@gmail.com>
Subject Re: svn commit: r724319 - in /activemq/camel/trunk/camel-core/src: main/java/org/apache/camel/component/file/ main/java/org/apache/camel/impl/ test/java/org/apache/camel/component/file/ test/java/org/apache/camel/impl/
Date Tue, 09 Dec 2008 02:53:59 GMT
Hi Claus,

The change of the DefaultComponent setProperties() will be blocked to
the components which extend the DefaultComponent and set the
useIntrospectionOnEndpoint to be false.

So I will remove the check of useIntrospectionOnEndpoint() in the
setProperties in my next commit to fixed the unit test error.

Willem


davsclaus@apache.org wrote:
> Author: davsclaus
> Date: Mon Dec  8 03:55:04 2008
> New Revision: 724319
> 
> URL: http://svn.apache.org/viewvc?rev=724319&view=rev
> Log:
> CAMEL-895: Added support for # notation in endpoint URIs to lookup a bean in the registry
> 
......
> 
> Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultComponent.java
> URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultComponent.java?rev=724319&r1=724318&r2=724319&view=diff
> ==============================================================================
> --- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultComponent.java
(original)
> +++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultComponent.java
Mon Dec  8 03:55:04 2008
> @@ -17,6 +17,7 @@
>  package org.apache.camel.impl;

> @@ -185,7 +186,48 @@
>       * Sets the bean properties on the given bean
>       */
>      protected void setProperties(Object bean, Map parameters) throws Exception {
> -        IntrospectionSupport.setProperties(getCamelContext().getTypeConverter(), bean,
parameters);
> +        if (useIntrospectionOnEndpoint()) {
> +            // set reference properties first as they use # syntax that fools the regular
properties setter
> +            setReferenceProperties(bean, parameters);
> +            IntrospectionSupport.setProperties(getCamelContext().getTypeConverter(),
bean, parameters);
> +        }
> +    }

Mime
View raw message