camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Willem Jiang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-1108) ParallelProcessing and executor flags are ignored in Multicast processor
Date Sat, 22 Nov 2008 03:40:05 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47571#action_47571
] 

Willem Jiang commented on CAMEL-1108:
-------------------------------------

Hi Vadim,

Thanks for patching this. 
Can you use svn diff  to create the patch and grand it with ASF license ?
Also the Unit test should help us to review your patch more quickly :).

Willem


> ParallelProcessing and executor flags are ignored in Multicast processor
> ------------------------------------------------------------------------
>
>                 Key: CAMEL-1108
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1108
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.5.0
>         Environment: Windows XP, Java 6
>            Reporter: Vadim Katz
>            Assignee: Willem Jiang
>         Attachments: MulticastProcessor.java
>
>
> The parallelProcessing and executor arguments are ignored in the constructor of MulticastProcessor.

> Here is a call that MulticastType makes
> {code:title=org.apache.camel.model.MulticastType.java}
>     return new MulticastProcessor(list, aggregationStrategy, isParallelProcessing(),
threadPoolExecutor);
> {code}
> MulticastProcessor ignores parallelProcessing and executor arguments and invokes a chain
constructor with "..,false, null,.."
> {code:title=org.apache.camel.processor.MulticastProcessor.java}
>     public MulticastProcessor(Collection<Processor> processors, AggregationStrategy
aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor) {
>         this(processors, aggregationStrategy, false, null, false);
>     }
>     public MulticastProcessor(Collection<Processor> processors, AggregationStrategy
aggregationStrategy, boolean parallelProcessing, ThreadPoolExecutor executor, boolean streaming)
{
>         notNull(processors, "processors");
>         this.processors = processors;
>         this.aggregationStrategy = aggregationStrategy;
>         this.isParallelProcessing = parallelProcessing;
>         if (isParallelProcessing) {
>             if (executor != null) {
>                 this.executor = executor;
>             } else { 
>                 // setup default Executor
>                 this.executor = new ThreadPoolExecutor(processors.size(), processors.size(),
0, TimeUnit.MILLISECONDS, new ArrayBlockingQueue<Runnable>(processors.size()));
>             }
>         }
>         this.streaming = streaming;
>     }
> {code}
> Attached a patch but have not tested it. Also need a unit test for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message