camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-964) loggingErrorHandler should default to ERROR and LoggingErrorHandlerBuilder should operate as a builder
Date Thu, 09 Oct 2008 10:43:52 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46281#action_46281
] 

Claus Ibsen commented on CAMEL-964:
-----------------------------------

Martin please re-attach the patch with Apache license granted

> loggingErrorHandler should default to ERROR and LoggingErrorHandlerBuilder should operate
as a builder
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-964
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-964
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 1.5.0
>            Reporter: Martin Gilday
>             Fix For: 1.5.0
>
>         Attachments: logger.patch
>
>
> Please see attached patch which changes the default level created by the LoggingErrorHandlerBuilder
to ERROR instead of INFO.
> Also some of the methods on this builder to not return "this".  This breaks the chain
when attempting to use the builder resulting in:
> LoggingErrorHandlerBuilder errorBuilder = loggingErrorHandler("my.logger.name");
> errorBuilder.setLevel(LoggingLevel.ERROR);
> errorHandler(errorBuilder);
> instead of:
> errorHandler(loggingErrorHandler("mylogger.name").level(LoggingLevel.ERROR));
> I have added on builder methods for "level" and for "log".  I have left the properties
that currently exist as following the pattern on DeadLetterChannelBuilder the builder method
names should not include "set".  Whoever applies the patch may wish to remove the getters
and setters, depending how they feel this will affect existing users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message