camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-910) loan broker example - feedback and minor review
Date Tue, 16 Sep 2008 18:25:52 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45744#action_45744
] 

Claus Ibsen commented on CAMEL-910:
-----------------------------------

#9
its not easily understood how the client can send using the template. Maybe divide the server
and client into each section. The client just need much less code than the server.

#10
webservice example. It is not clear that its the *true* parameter that turns the multicast
into parallel mode. This is not documented to well in the code.

> loan broker example - feedback and minor review
> -----------------------------------------------
>
>                 Key: CAMEL-910
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-910
>             Project: Apache Camel
>          Issue Type: Task
>          Components: documentation, examples
>    Affects Versions: 1.4.0
>            Reporter: Claus Ibsen
>            Assignee: Willem Jiang
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> First of all I think we need to promote this great example some more. Maybe it should
be easier to find on our wiki site.
> I will post findings in this ticket:
> #1
> Link to EIP book loan broker sample doesnt work
> #2
> I think the 2 parts in the introduction should be listed as bullets (one for JMS, one
for webservice)
> #3
> spelling (comman in the sentence below)
> credit agency , and banks)
> #4
> Maybe the exchange pattern InOnly, InOut is not easily understood by new users and non
JBI/ServiceMix end-users. Maybe use terms such as sync/async instead (and list the MEP in
parathes)
> #5
> Could "test-jms" component name be renamed to jms or activemq or something with non test?
> #6
> multicast().to() ah clever if its really using a multicast ;) I didn't know that we have
the .to on multicase. Are you sure its working as expected? and it should not be multicase("bank1",
"bank2", ...) without the to?
> #7
> Use the getHeader with the expected type as 2nd param, to avoid plain java type cast
>   String ssn = (String)exchange.getIn().getHeader(Constants.PROPERTY_SSN);
> #8
> The aggregator. I am wondering if we have or should have a counter build in Camel so
you can use a build in header instead of "remebering" to code this yourself
> result.setProperty("aggregated", old + 1);
> will continue...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message