Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: camel-dev@activemq.apache.org
Message-ID: <256730953.1218263332646.JavaMail.jira@brutus>
Date: Fri, 8 Aug 2008 23:28:52 -0700 (PDT)
From: "Martin Krasser (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Created: (CAMEL-803) ValidatingProcessor not thread-safe
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

ValidatingProcessor not thread-safe
-----------------------------------

                 Key: CAMEL-803
                 URL: https://issues.apache.org/activemq/browse/CAMEL-803
             Project: Apache Camel
          Issue Type: Bug
          Components: camel-core
    Affects Versions: 1.4.0
            Reporter: Martin Krasser


The method org.apache.camel.processor.validation.ValidatingProcessor.process() is executed concurrently but error information is stored in a shared errorHandler. Because each thread calls errorHandler.reset() it may clean errors written by another thread. The easiest way to fix this issue would be a synchronized block:

{code:java|title=ValidatingProcessor.java}
...
synchronized (errorHandler) {
    errorHandler.reset();
    validator.setErrorHandler(errorHandler);
    
    DOMResult result = new DOMResult();
    validator.validate(source, result);
    
    errorHandler.handleErrors(exchange, schema, result);
}
... 
{code}

The disadvantage of this solution is that is serializes threads. A locally created error handler would be preferrable ...


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.