Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: camel-dev@activemq.apache.org
Message-ID: <637122756.1212924180358.JavaMail.jira@brutus>
Date: Sun, 8 Jun 2008 04:23:00 -0700 (PDT)
From: "Christian Schneider (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Closed: (CAMEL-547) remove cycle between builder and spi
In-Reply-To: <1746871229.1211647314379.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/activemq/browse/CAMEL-547?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schneider closed CAMEL-547.
-------------------------------------

    Resolution: Duplicate

Please see the newer issue with the better patch

> remove cycle between builder and spi
> ------------------------------------
>
>                 Key: CAMEL-547
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-547
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.3.0
>            Reporter: Christian Schneider
>            Assignee: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 1.5.0
>
>         Attachments: Main cluster (11).png, routecontext.patch
>
>
> Currently the spi package references builder.RouteBuilder. This creates a=
 bad cycle in Camel as builder is one of the top level packages and spi is =
one of the lowest level packages. The method where RouteBuilder is used is =
in CamelContext.addRoutes(RouteBuilder builder). I think this reference is =
not necessary. CamelContext already has a method addRoutes(Collection<Route=
> routes).=20
> So instead of calling camelContext.addRoutes(builder) I think the better =
way would to call:
> builder.setContext(camelContext);
> builder.addRoutesToContext(); // This is a new method that replaces the f=
unctionality of CamelContext.addRoutes(RouteBuilder builder)
> This way we will also cut some part of the cycle between impl and builder=
. impl.DefaultCamelContext references both RouteBuilder and BuilderSupport =
from the builder package. Both will not be necessary anymore as as soon as =
we get rid of the addRoutes method.
> This way CamelContext does not have to know anything about it=C2=B4s buil=
der. What do you think about this change?

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.