Return-Path: Delivered-To: apmail-activemq-camel-dev-archive@locus.apache.org Received: (qmail 77897 invoked from network); 4 Jun 2008 13:17:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Jun 2008 13:17:22 -0000 Received: (qmail 63440 invoked by uid 500); 4 Jun 2008 13:17:25 -0000 Delivered-To: apmail-activemq-camel-dev-archive@activemq.apache.org Received: (qmail 63419 invoked by uid 500); 4 Jun 2008 13:17:24 -0000 Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: camel-dev@activemq.apache.org Delivered-To: mailing list camel-dev@activemq.apache.org Received: (qmail 63404 invoked by uid 99); 4 Jun 2008 13:17:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2008 06:17:24 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jun 2008 13:16:44 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9FC05234C134 for ; Wed, 4 Jun 2008 06:17:00 -0700 (PDT) Message-ID: <514941162.1212585420596.JavaMail.jira@brutus> Date: Wed, 4 Jun 2008 06:17:00 -0700 (PDT) From: "Hadrian Zbarcea (JIRA)" To: camel-dev@activemq.apache.org Subject: [jira] Commented: (CAMEL-527) Break dependency cycle between camel and camel.impl In-Reply-To: <843841364.1211065543466.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43222#action_43222 ] Hadrian Zbarcea commented on CAMEL-527: --------------------------------------- Hi, I think this kind of changes have a big impact on other projects using camel, such as activemq and servicemix. Not only code changes are required in these projects, but their ability to work with different versions of camel. This has a cascading effect on users of such projects who may have to consider updating to camel 1.4 too. I would suggest asking their opinion in the future before making such changes. My $0.02, Hadrian > Break dependency cycle between camel and camel.impl > --------------------------------------------------- > > Key: CAMEL-527 > URL: https://issues.apache.org/activemq/browse/CAMEL-527 > Project: Apache Camel > Issue Type: Improvement > Components: camel-core > Affects Versions: 1.3.0 > Reporter: Christian Schneider > Assignee: Hadrian Zbarcea > Fix For: 1.4.0 > > Attachments: producertemplate.patch, servicehelper.patch > > Original Estimate: 3 hours > Remaining Estimate: 3 hours > > Currently there is a dependency cycle between camel and camel.impl. While I think there is no problem when impl uses camel the other direction should not occur. Luckily there ist only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from impl. > As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper is already in util and Service as well as ServiceSupport do not need any other classes. This would help to break the dependency cycle and at the same time move some classes out of the already quite big camel package. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.