Return-Path: Delivered-To: apmail-activemq-camel-dev-archive@locus.apache.org Received: (qmail 57990 invoked from network); 18 Jun 2008 05:13:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Jun 2008 05:13:53 -0000 Received: (qmail 77533 invoked by uid 500); 18 Jun 2008 05:13:55 -0000 Delivered-To: apmail-activemq-camel-dev-archive@activemq.apache.org Received: (qmail 77515 invoked by uid 500); 18 Jun 2008 05:13:55 -0000 Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: camel-dev@activemq.apache.org Delivered-To: mailing list camel-dev@activemq.apache.org Received: (qmail 77504 invoked by uid 99); 18 Jun 2008 05:13:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jun 2008 22:13:55 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jun 2008 05:13:14 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 60875234C138 for ; Tue, 17 Jun 2008 22:13:00 -0700 (PDT) Message-ID: <1738544897.1213765980375.JavaMail.jira@brutus> Date: Tue, 17 Jun 2008 22:13:00 -0700 (PDT) From: "Willem Jiang (JIRA)" To: camel-dev@activemq.apache.org Subject: [jira] Closed: (CAMEL-573) Remove cycle between builder and impl In-Reply-To: <1519849953.1212534180270.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang closed CAMEL-573. ------------------------------ > Remove cycle between builder and impl > ------------------------------------- > > Key: CAMEL-573 > URL: https://issues.apache.org/activemq/browse/CAMEL-573 > Project: Apache Camel > Issue Type: Improvement > Components: camel-core > Reporter: Christian Schneider > Assignee: Willem Jiang > Fix For: 1.4.0 > > Attachments: remove_cycle_between_impl_and_builder.patch, remove_cycle_between_impl_and_builder.patch > > > The following classes from impl are only used in builder. They should be moved there. > - NoRouteBuilder > - PredicateSupport > - BinaryPredicateSupport > The last dependency from impl to builder is in PredicateSupport. The method matches uses the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this method does not depend on anything so I would move it to util.ObjectHelper. > I have added a patch with alle these modifications. According to my structure 101 I see only improvements in the dependecies. The cycle between impl an builder vanishes. I think there is almost no risk in doing this modification. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.