camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Willem Jiang <willem.ji...@gmail.com>
Subject Re: [VOTE] Release apache-camel-1.4
Date Mon, 30 Jun 2008 12:37:35 GMT
Hi,

I think it will OK for moving the "support" class into sr/main, we can 
mark junit to be provided scope so we will not ship the junit.jar.
When the client wants to use CamelContextSupport.class from camel-core , 
he need to provide junit jar.

In Camel 1.4 release , I think we do not include any camel-core or 
camel-spring test jar in the bundler jar, we could put these jars into 
the lib/option directory.

Willem
Claus Ibsen wrote:
> Hi
>
> I do think this is something for Camel 1.5 or later.
>
> William if I should understand you correctly:
>
> - You want to only move test "support" classes from src/test to src/main?
>   (eg. CamelContextSupport.class). Eg. only the classes that are used for test support
and not any xxxTest itself?
>
> If so we should be careful not to require any junit.jar or other dependencies at runtime
for camel-core etc.
>
>
>
> Med venlig hilsen
>  
> Claus Ibsen
> ......................................
> Silverbullet
> Skovsgårdsvænget 21
> 8362 Hørning
> Tlf. +45 2962 7576
> Web: www.silverbullet.dk
>
> -----Original Message-----
> From: Willem Jiang [mailto:willem.jiang@gmail.com] 
> Sent: 30. juni 2008 14:02
> To: camel-dev@activemq.apache.org
> Subject: Re: [VOTE] Release apache-camel-1.4
>
> Hi Clause,
>
> I just fight with the maven-shade-plugin for a while ,  I found I 
> could't just include the *Support.class in camel-core-*-test.jar and 
> camel-spring-*-test.jar.
>
> I'd like to move these test support classes into source main directory , 
> so we can walk around the maven-shade-plugin's issue and we can also get 
> the convince  for  not  including the  test.jars  in the pom.xml.
>
> Any thought?
>
> Willem
> Claus Ibsen wrote:
>   
>> Hi
>>
>> In the RC2 distro the big jar file apache-camel-1.4.0.jar (2mb) contains unit tests,
log4j.properties, spring xml test files etc. We ought to clean this up before releasing a
new version.
>>
>> Notice: In Camel 1.3 there are no big jar file!
>>
>> CAMEL-650 is the JIRA ticket.
>>
>> Med venlig hilsen
>>  
>> Claus Ibsen
>> ......................................
>> Silverbullet
>> Skovsgårdsvænget 21
>> 8362 Hørning
>> Tlf. +45 2962 7576
>> Web: www.silverbullet.dk
>> -----Original Message-----
>> From: Claus Ibsen [mailto:ci@silverbullet.dk] 
>> Sent: 29. juni 2008 19:20
>> To: camel-dev@activemq.apache.org
>> Subject: RE: [VOTE] Release apache-camel-1.4
>>
>> Hi
>>
>> I would love to include CAMEL-634 in the 1.4 release.
>>
>> Basically our TransactionInterceptor for Transactioncal Client EIP pattern is broken.
It doesn't work.
>>
>> However one issue in the CAMEL-634 patch is that it introduces an ExchangeProperty
for a clever way of setting and getting properties from Exchange. If the patch is comitted
as is, we get this new feature. However as we use properties on Exchanges in many places to
store "exceptions, retry count, original filename, etc. etc." we should consider if this new
fancy stuff is something we want in Camel and over time migrate the existing stuff to uset
this new technique
>>
>> Also I have some comments on CAMEL-634 I want to have clarified before it can be
comitted. 
>>
>> And the fact that it solves an end-users problem he had with this for more than 15
hours. If not included he could get more frustrated and leave Camel. So I do think we should
try to get it in.
>>
>> I have also some other unit tests on my laptop for another end-user that has problems
with storing in the database using two processors in one transaction. We could include these
unit tests as well and have them SNIPPET ready for wiki documentation.
>>
>> Okay my Sunday is turning into TV mode, as the euro2008 final is tonight.
>>
>>
>>
>> Med venlig hilsen
>>  
>> Claus Ibsen
>> ......................................
>> Silverbullet
>> Skovsgårdsvænget 21
>> 8362 Hørning
>> Tlf. +45 2962 7576
>> Web: www.silverbullet.dk
>>
>> -----Original Message-----
>> From: Claus Ibsen [mailto:ci@silverbullet.dk] 
>> Sent: 27. juni 2008 12:21
>> To: camel-dev@activemq.apache.org
>> Subject: RE: [VOTE] Release apache-camel-1.4
>>
>> Damm fat fingers.
>>
>> Also there might be a problem with the old fashion of disabling jmx with useJmx="false"
that might not work and thus enable JMX. 
>>
>> And Willem has an issue with the loan broaker example.
>>
>> So I vote -1
>>
>> Med venlig hilsen
>>  
>> Claus Ibsen
>> ......................................
>> Silverbullet
>> Skovsgårdsvænget 21
>> 8362 Hørning
>> Tlf. +45 2962 7576
>> Web: www.silverbullet.dk
>>
>> -----Original Message-----
>> From: Claus Ibsen 
>> Sent: 27. august 2008 12:20
>> To: 'camel-dev@activemq.apache.org'
>> Subject: RE: [VOTE] Release apache-camel-1.4
>>
>> Hi Gert
>>
>> Great catch. I do think we should cut a new release next week giving time to fix
this issue. Also there might be a problem with the old fashion disabling jmx
>>
>> Med venlig hilsen
>>  
>> Claus Ibsen
>> ......................................
>> Silverbullet
>> Skovsgårdsvænget 21
>> 8362 Hørning
>> Tlf. +45 2962 7576
>> Web: www.silverbullet.dk
>> -----Original Message-----
>> From: Gert Vanthienen [mailto:gert.vanthienen@skynet.be] 
>> Sent: 27. juni 2008 10:57
>> To: camel-dev@activemq.apache.org
>> Subject: Re: [VOTE] Release apache-camel-1.4
>>
>> L.S.,
>>
>> Just found a minor problem in the release: I think the spring.schemas 
>> files are missing some entries and contain others that shouldn't be there.
>>
>> An example:  the camel-spring.xsd has everything that's required
>> http\://activemq.apache.org/camel/schema/spring/camel-spring.xsd=camel-spring.xsd
>> http\://activemq.apache.org/camel/schema/spring/camel-spring-1.0.0.xsd=camel-spring.xsd
>> http\://activemq.apache.org/camel/schema/spring/camel-spring-1.1.0.xsd=camel-spring.xsd
>> http\://activemq.apache.org/camel/schema/spring/camel-spring-1.2.0.xsd=camel-spring.xsd
>> http\://activemq.apache.org/camel/schema/spring/camel-spring-1.3.0.xsd=camel-spring.xsd
>> http\://activemq.apache.org/camel/schema/spring/camel-spring-1.4.0.xsd=camel-spring.xsd
>>
>> ... but if you look at the other entries, they seem to be missing some 
>> things.  An example:
>> http\://activemq.apache.org/camel/schema/osgi/camel-osgi.xsd=camel-osgi.xsd
>> http\://activemq.apache.org/camel/schema/osgi/camel-osgi-1.1.xsd=camel-osgi.xsd
>> http\://activemq.apache.org/camel/schema/osgi/camel-osgi-1.1-SNAPSHOT.xsd=camel-osgi.xsd
>> http\://activemq.apache.org/camel/schema/osgi/camel-osgi-1.2.xsd=camel-osgi.xsd
>> http\://activemq.apache.org/camel/schema/osgi/camel-osgi-1.2-SNAPSHOT.xsd=camel-osgi.xsd
>>
>> I don't think we should put the SNAPSHOTs in there and the latest 
>> released version camel-osgi-1.3.0.xsd isn't even in there.  Using plain 
>> Spring, these missing entries can cause Spring to go off to the website 
>> every time it loads the context just to get the schema or even worse, 
>> not getting the XSD at all if behind a proxy.  I'll fix it in trunk 
>> ASAP, but I'm unsure whether it is a release blocker...
>>
>> Regards,
>>
>> Gert
>>
>>
>>
>> Hadrian Zbarcea wrote:
>>   
>>     
>>> This is a vote to release camel 1.4
>>>
>>> After 2 1/2 months a new Camel is out.  Another fantastic community 
>>> effort with 179 issues fixed.
>>> Many thanks for all the hard work!
>>>
>>> The staging area is at:
>>> http://people.apache.org/~hadrian/apache-camel-1.4.0-RC2/maven2
>>>
>>> The tarballs are here:
>>> http://people.apache.org/~hadrian/apache-camel-1.4.0-RC2/maven2/org/apache/camel/apache-camel/1.4.0/

>>>
>>>
>>> Please vote to approve this release binary.  The vote will be open for 
>>> at least 72 hours.
>>>
>>> [ ] +1 Release the binary as Apache Camel 1.4.0
>>> [ ] -1 Veto the release (provide specific comments)
>>>
>>> Here's my +1
>>> Hadrian
>>>     
>>>       
>>   
>>     
>
>
>   


Mime
View raw message