camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claus Ibsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-573) Remove cycle between builder and impl
Date Wed, 04 Jun 2008 04:25:00 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43209#action_43209
] 

Claus Ibsen commented on CAMEL-573:
-----------------------------------

Christian could you re add the patch with the ASF license granted. (ie apache icon next to
the attached file).

JIRA has an issue that you can not do this when you create the ticket. You have to do it in
2 steps
1. Create the ticket
2. Attach the patch file with the ASF license granted.

Otherwise a really great patch that does remove the tangle. Keep up the great discoveries
and good work you are doing. It is coming along nice and steady.

> Remove cycle between builder and impl
> -------------------------------------
>
>                 Key: CAMEL-573
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-573
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Christian Schneider
>             Fix For: 1.4.0
>
>         Attachments: remove_cycle_between_impl_and_builder.patch
>
>
> The following classes from impl are only used in builder. They should be moved there.
> - NoRouteBuilder
> - PredicateSupport
> - BinaryPredicateSupport
> The last dependency from impl to builder is in PredicateSupport. The method matches uses
the static method PredicateBuilder.evaluateValuePredicate(value). The implementation of this
method does not depend on anything so I would move it to util.ObjectHelper. 
> I have added a patch with alle these modifications. According to my structure 101 I see
only improvements in the dependecies. The cycle between impl an builder vanishes. I think
there is almost no risk in doing this modification.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message