Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm
Precedence: bulk
Reply-To: camel-dev@activemq.apache.org
Message-ID: <1583793693.1210830823493.JavaMail.jira@brutus>
Date: Wed, 14 May 2008 22:53:43 -0700 (PDT)
From: "Christian Schneider (JIRA)" <jira@apache.org>
To: camel-dev@activemq.apache.org
Subject: [jira] Commented: (CAMEL-264) The spi package should not depend on
 implementation packages
In-Reply-To: <26204098.1197770487592.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/activemq/browse/CAMEL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42805#action_42805 ] 

Christian Schneider commented on CAMEL-264:
-------------------------------------------

I have used Eclipse 3.3 and Eclipse 3.4 M7. Both had the same problem. When I tried extract interface on a class with much less references it worked.

> The spi package should not depend on implementation packages
> ------------------------------------------------------------
>
>                 Key: CAMEL-264
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-264
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Christian Schneider
>             Fix For: 1.4.0
>
>         Attachments: Main cluster (12).png, new Main cluster (12).png, screenshot-1.jpg
>
>
> Currently spi.LifecycleStrategy depends on impl.RouteContext.
> This is bad because the spi is an interface package that should have no dependencies on implementation packages.
> The solution is to rename RouteContext to RouteContextImpl, extract an interface class RouteContext from the implementation and put this interface into spi. So spi is self contained.
> The other problem is that spi.InstrumentationAgent depends on management.CamelNamingStrategy. In this case I would suggest to simply remove the method getNamingStrategy from the IntrumentationAgent. Instead I add the naming strategy param to the constructor of InstrumentationLifecycleStrategy. So the dependency disappears. Of course this way the naming strategy is no longer part of the spi but I think it is an internal thing anyway. What do you think?
> I will attach a patch for the issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.