camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William Tam" <email.w...@gmail.com>
Subject Re: svn commit: r660222 - /activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/management/JmxInstrumentationUsingDefaultsTest.java
Date Tue, 27 May 2008 15:02:13 GMT
Hi Willem,

Regarding the issue  of "adding the InstrumentationProcessor for the
route",  I have raised it in the camel-dev [1].  My suggestion is to
revert the part of r658240  that affected
InstrumentationLifecycleStrategy.onRouteContextCreate ().   I think
r660216 further impacts the JMX support.   Please review the patch
attached.  It should resolve the issue.  It passes the jmx test that
had been disabled and passes the CamelChoiceWithManagementTest. as
well.

[1] http://www.nabble.com/Re%3A-svn-commit%3A-r658240---in--activemq-camel-trunk%3A-camel-core--camel-core-src-main-java-org-apache-camel-impl--camel-core-src-main-java-org-apache-camel-management--camel-core-src-main-java-org-apache-camel-model--camel-core-src-main-java-org-apache-td17397480s22882.html

Thanks,
William


On Mon, May 26, 2008 at 9:43 PM, Willem Jiang <willem.jiang@gmail.com> wrote:
> Hi William,
>
> Please check out the  InstrumentationLifecycleStrategy[1], I comment out
> some codes which will add interceptor to the route type instance and produce
> a process cycle when instruments a router with choice type.
> BTW,  adding the InstrumenationProcessor for the route as an interceptor is
> not right, the interceptor will be used to wrap all the processors which are
> wrapped by the InstrumentationInterceptStrategy.
>
> Here is also a testcase[2] to show the error, you can reproduce the error by
> uncommenting  the codes in the InstrumentationLifecycleStrategy.
>
> [1]https://svn.apache.org/repos/asf/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/management/InstrumentationLifecycleStrategy.java
> [2]https://svn.apache.org/repos/asf/activemq/camel/trunk/components/camel-spring/src/test/java/org/apache/camel/spring/CamelChoiceWithManagementTest.java
>
> Willem
>
> William Tam wrote:
>>
>> Hi Willem,
>>
>> Is it the test's fault or the code's fault?  Or, is it disabled
>> temporarily?
>>
>> Thanks,
>> William
>>
>> On Mon, May 26, 2008 at 12:05 PM,  <ningjiang@apache.org> wrote:
>>
>>>
>>> Author: ningjiang
>>> Date: Mon May 26 09:05:21 2008
>>> New Revision: 660222
>>>
>>> URL: http://svn.apache.org/viewvc?rev=660222&view=rev
>>> Log:
>>> Fixed the build, by disabling the route couter verification
>>>
>>> Modified:
>>>
>>> activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/management/JmxInstrumentationUsingDefaultsTest.java
>>>
>>> Modified:
>>> activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/management/JmxInstrumentationUsingDefaultsTest.java
>>> URL:
>>> http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/management/JmxInstrumentationUsingDefaultsTest.java?rev=660222&r1=660221&r2=660222&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/management/JmxInstrumentationUsingDefaultsTest.java
>>> (original)
>>> +++
>>> activemq/camel/trunk/camel-core/src/test/java/org/apache/camel/management/JmxInstrumentationUsingDefaultsTest.java
>>> Mon May 26 09:05:21 2008
>>> @@ -44,23 +44,23 @@
>>>        Set s = iAgent.getMBeanServer().queryNames(
>>>                new ObjectName(domainName + ":type=endpoint,*"), null);
>>>        assertEquals("Could not find 2 endpoints: " + s, 2, s.size());
>>> -
>>> +
>>>        s = iAgent.getMBeanServer().queryNames(
>>>                new ObjectName(domainName + ":type=context,*"), null);
>>>        assertEquals("Could not find 1 context: " + s, 1, s.size());
>>> -
>>> +
>>>        s = iAgent.getMBeanServer().queryNames(
>>>                new ObjectName(domainName + ":type=processor,*"), null);
>>>        assertEquals("Could not find 1 processor: " + s, 1, s.size());
>>> -
>>> +
>>>        s = iAgent.getMBeanServer().queryNames(
>>>                new ObjectName(domainName + ":type=route,*"), null);
>>>        assertEquals("Could not find 1 route: " + s, 1, s.size());
>>> -
>>> +
>>>        if (sleepSoYouCanBrowseInJConsole) {
>>>            Thread.sleep(100000);
>>>        }
>>> -
>>> +
>>>    }
>>>
>>>    public void testCounters() throws Exception {
>>> @@ -71,7 +71,7 @@
>>>        resultEndpoint.assertIsSatisfied();
>>>
>>>        MBeanServer mbs = iAgent.getMBeanServer();
>>> -        verifyCounter(mbs, new ObjectName(domainName +
>>> ":type=route,*"));
>>> +        //verifyCounter(mbs, new ObjectName(domainName +
>>> ":type=route,*"));
>>>        verifyCounter(mbs, new ObjectName(domainName +
>>> ":type=processor,*"));
>>>
>>>    }
>>> @@ -114,7 +114,7 @@
>>>                      valueofMeanProcessingTime);
>>>        assertTrue(valueofMeanProcessingTime >= valueofMinProcessingTime
>>>                   && valueofMeanProcessingTime <=
>>> valueofMaxProcessingTime);
>>> -
>>> +
>>>    }
>>>
>>>    protected void enableJmx() {
>>>
>>>
>>>
>>>
>>
>>
>
>

Mime
View raw message