camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadrian Zbarcea (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-527) Break dependency cycle between camel and camel.impl
Date Fri, 23 May 2008 15:23:54 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42980#action_42980
] 

Hadrian Zbarcea commented on CAMEL-527:
---------------------------------------

fwiw, I don't think moving ServiceSupport and ServiceHelper to oac is a good idea.

My S101 shows 76 deps from impl->util and 13, from util->impl, so impl should depend
on util I guess.  In that case the dependency between ServiceHelper and ServiceSupport is
ok the way it is.

> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
>                 Key: CAMEL-527
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-527
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.3.0
>            Reporter: Christian Schneider
>            Assignee: Claus Ibsen
>             Fix For: 1.4.0
>
>         Attachments: servicehelper.patch
>
>   Original Estimate: 3 hours
>  Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there
is no problem when impl uses camel the other direction should not occur. Luckily there ist
only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from
impl. 
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper
is already in util and Service as well as ServiceSupport do not need any other classes. This
would help to break the dependency cycle and at the same time move some classes out of the
already quite big camel package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message