camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-527) Break dependency cycle between camel and camel.impl
Date Sat, 24 May 2008 13:15:54 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43001#action_43001
] 

Christian Schneider commented on CAMEL-527:
-------------------------------------------

I have added a patch for the CamelTemplate stuff. I think it should work out quite well. The
CamelTemplate is gone in this patch this of course means people have to adapt their code.
But even if we only had moved CamelTemplate they would have to change their code as the import
is from a different package. I think this way it is much cleaner and the implementation is
much better encapsulated. If we document this step well it should be no big problem for people.
I think the idea of decribing what we changed in Release notes and wiki is a very important
thing.

> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
>                 Key: CAMEL-527
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-527
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.3.0
>            Reporter: Christian Schneider
>            Assignee: Hadrian Zbarcea
>             Fix For: 1.4.0
>
>         Attachments: producertemplate.patch, servicehelper.patch
>
>   Original Estimate: 3 hours
>  Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there
is no problem when impl uses camel the other direction should not occur. Luckily there ist
only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from
impl. 
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper
is already in util and Service as well as ServiceSupport do not need any other classes. This
would help to break the dependency cycle and at the same time move some classes out of the
already quite big camel package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message