camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Schneider (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-527) Break dependency cycle between camel and camel.impl
Date Sat, 24 May 2008 08:11:54 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42994#action_42994
] 

Christian Schneider commented on CAMEL-527:
-------------------------------------------

@Hadrian: I have also seen the other cycles and thought to address them one after the other
in jira issues. Do you think this is a good idea or should we rather make a plan first?

About the ProducerTemplate: For me ProducerTemplate looks great. I also have an idea how to
create it. What about a factory method in CamelContext?

Like:
ProducerTemplate pt = camelContext.createProducerTemplate();

Inside the unit tests it seems there are only a few places where CamelTemplate is used directly.
I think it is a good idea to stay with the name ProducerTemplate as it cleary states what
you can do with it. CamelTemplate is too general. 

We could then rename CamelTemplate to DefaultProducerTemplate and move it to impl. It will
then be referenced only from DefaultCamelContext.

> Break dependency cycle between camel and camel.impl
> ---------------------------------------------------
>
>                 Key: CAMEL-527
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-527
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 1.3.0
>            Reporter: Christian Schneider
>            Assignee: Hadrian Zbarcea
>             Fix For: 1.4.0
>
>         Attachments: servicehelper.patch
>
>   Original Estimate: 3 hours
>  Remaining Estimate: 3 hours
>
> Currently there is a dependency cycle between camel and camel.impl. While I think there
is no problem when impl uses camel the other direction should not occur. Luckily there ist
only one case where this happens. The class CamelTemplate from camel uses ServiceSupport from
impl. 
> As a solution I would suggest to move ServiceSupport and Service to util. ServiceHelper
is already in util and Service as well as ServiceSupport do not need any other classes. This
would help to break the dependency cycle and at the same time move some classes out of the
already quite big camel package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message