camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadrian Zbarcea (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-298) Remove tangle between impl and impl.converter
Date Thu, 17 Apr 2008 04:49:43 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42334#action_42334
] 

Hadrian Zbarcea commented on CAMEL-298:
---------------------------------------

Claus, you're absolutely right, my bad.  I would go with b).  I don't think anybody would
have used it so I wouldn't bother deprecating it.

> Remove tangle between impl and impl.converter
> ---------------------------------------------
>
>                 Key: CAMEL-298
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-298
>             Project: Apache Camel
>          Issue Type: Improvement
>          Components: camel-core
>            Reporter: Christian Schneider
>            Assignee: Claus Ibsen
>             Fix For: 1.4.0
>
>         Attachments: after patch no tangle.png, before patch.png
>
>
> Currently impl and impl.converter reference each other. If possible such cycles should
be avoided.
> When I looked into it I found that impl.converter references only a single class CachingInjector.
No other class in camel-core seems to use this class. So my suggestion is to move CachingInjector
to impl.converter. So the cycle i removed. As far as I can see this should cause no ther issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message