camel-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Strachan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (CAMEL-412) OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Date Mon, 31 Mar 2008 14:36:33 GMT

    [ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41932#action_41932
] 

James Strachan commented on CAMEL-412:
--------------------------------------

I've applied half of your patch - that if the executable property is empty or null then the
generation is skipped.

BTW its maybe an idea not to reformat the code before sending patches in the future, its kinda
hard to see what you really did :)

I'm not sure if we should remove the default executable name for DOT. Its up to users to use
the plugin or not - you can also use [maven profiles|http://maven.apache.org/guides/introduction/introduction-to-profiles.html]
to only enable the plugin if its activated and so forth. So I like the idea of the plugin
invoking "dot" on the path by default (as thats gonna work on most OSes).
 
Maybe to disable the use of dot we can just use another property? I've added a useDot property
so folks can disable the running of dot - would that do the trick?

> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
>                 Key: CAMEL-412
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-412
>             Project: Apache Camel
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.3.0
>         Environment: OSX
>            Reporter: Kevin Ross
>             Fix For: 1.4.0
>
>         Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file
if there is no value for <executable/> in the pom.xml.  The parameter was defaulted.
> #. removed the default.
> #. added log message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message