Return-Path: Delivered-To: apmail-activemq-camel-dev-archive@locus.apache.org Received: (qmail 26201 invoked from network); 19 Jan 2008 16:26:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Jan 2008 16:26:45 -0000 Received: (qmail 56496 invoked by uid 500); 19 Jan 2008 16:26:35 -0000 Delivered-To: apmail-activemq-camel-dev-archive@activemq.apache.org Received: (qmail 56438 invoked by uid 500); 19 Jan 2008 16:26:34 -0000 Mailing-List: contact camel-dev-help@activemq.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: camel-dev@activemq.apache.org Delivered-To: mailing list camel-dev@activemq.apache.org Received: (qmail 56429 invoked by uid 99); 19 Jan 2008 16:26:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Jan 2008 08:26:34 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 19 Jan 2008 16:26:29 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id CDB60714045 for ; Sat, 19 Jan 2008 08:26:21 -0800 (PST) Message-ID: <2251575.1200759981813.JavaMail.jira@brutus> Date: Sat, 19 Jan 2008 08:26:21 -0800 (PST) From: "Christian Schneider (JIRA)" To: camel-dev@activemq.apache.org Subject: [jira] Commented: (CAMEL-298) Remove tangle between impl and impl.converter In-Reply-To: <27421072.1200759862086.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/activemq/browse/CAMEL-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41081#action_41081 ] Christian Schneider commented on CAMEL-298: ------------------------------------------- Should I append a patch for this? > Remove tangle between impl and impl.converter > --------------------------------------------- > > Key: CAMEL-298 > URL: https://issues.apache.org/activemq/browse/CAMEL-298 > Project: Apache Camel > Issue Type: Improvement > Components: camel-core > Reporter: Christian Schneider > Fix For: 1.3.0 > > Attachments: after patch no tangle.png, before patch.png > > > Currently impl and impl.converter reference each other. If possible such cycles should be avoided. > When I looked into it I found that impl.converter references only a single class CachingInjector. No other class in camel-core seems to use this class. So my suggestion is to move CachingInjector to impl.converter. So the cycle i removed. As far as I can see this should cause no ther issues. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.